This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Simplify dirty bit management #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| * @param {!string} text The text to replace the contents of the document with. | ||
| */ | ||
| Document.prototype.setText = function(text) { | ||
| console.assert(this._editor != null); |
There was a problem hiding this comment.
I always go back and forth on whether it's worth it to have an assert() if the next line of code is guaranteed to crash anyway (NPE in this case)... but feel free to keep it in if you like it.
There was a problem hiding this comment.
I was just following the existing code from getText()...I'm fine with removing it.
|
Done with comments. Looks great other than those few nits. |
|
Looks good. Merging... |
peterflynn
added a commit
that referenced
this pull request
Jan 28, 2012
Simplify dirty bit management; fix issue #152 (Intermittent problem where file with unsaved changes isn't dirty)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #152 exposed a problem with our dirty bit management, which was relying on CodeMirror's undo history. Because CodeMirror limits the size of its undo history, our logic for figuring out when to clear the dirty bit due to an undo was incorrect.
The real fix for this would be to add the dirty bit tracking to CodeMirror. For now, we're simplifying the dirty bit management so that we simply mark documents as dirty as soon as you make a change, and only mark them clean again on save. If you undo back to your previous save state, the document is still marked dirty. This avoids the data loss issue from 152, but is not as good from the user's point of view. We'll add a user story to the product backlog to get back to the previous functionality.