This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
InApp Notifications #14715
Merged
InApp Notifications #14715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boopeshmahendran
suggested changes
Apr 23, 2019
src/extensions/default/InAppNotifications/htmlContent/notificationContainer.html
Outdated
Show resolved
Hide resolved
boopeshmahendran
suggested changes
Apr 23, 2019
shubhsnov
reviewed
Apr 23, 2019
|
@boopeshmahendran and @shubhsnov Thanks a ton for reviewing this PR minutely under short notice 💯 |
boopeshmahendran
approved these changes
Apr 24, 2019
| float: right; | ||
| text-align: center; | ||
| width: auto; | ||
| min-width: 66px; |
There was a problem hiding this comment.
nit: some fomatting issues in this file.
shubhsnov
approved these changes
Apr 25, 2019
|
LGTM 👍 Tested with multiple platforms, versions etc. Everything is working fine. With this, we can target notifications in the future. Thanks, @swmitra for this brilliant contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the required infrastructure to display App notifications created by Brackets publisher with the ability to filter applicability of the notifications based on multiple parameters. A sample notifications file (localized) hosted from S3 would look like -
{ "notifications": [ { "sequence": "1555874975721", "silent": false, "filters": { "platforms": ["OSX"], "version": "1.14", "locales": ["en"], "builds": [], "extensions": [], "lastUsed": "" }, "html": "<div><span>Web development and design trends are changing at a rapid pace. We want to hear how new paradigms and tools are impacting you and the way you work!</span><a id='banner-button' href='https://adobe.ly/bracketsiosurvey'>Take the Brackets Survey</a></div>", "actionables": "#banner-button", "expiry" : "1556044200000" } ] }