This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update CSS Code Hints pseudo-selectors #13345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pseudo-classes – `:default` – `:dir()` – `:focus-within` – `:indeterminate` – `:matches()` – `:placeholder-shown`. Add pseudo-element `::placeholder`. Fix alphabetical order, space around `:`.
swmitra
suggested changes
May 3, 2017
"nth-last-of-type(n)": {"desc": "Selects every element that is the nth element of its parent, counting from the last child", "text":"nth-last-of-type()"}, | ||
"nth-of-type(n)": {"desc": "Selects every element that is the nth element of its parent", "text":"nth-of-type(n)"}, | ||
"only-of-type": {"desc": "Selects every element that is the only element of this type of its parent"}, | ||
"matches(selectors)": {"decs": "Selects every element that is matched by one or more selectors in the 'selectors' list"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the spelling of description key.
"nth-last-of-type(n)": {"desc": "Selects every element that is the nth element of its parent, counting from the last child", "text":"nth-last-of-type()"}, | ||
"nth-of-type(n)": {"desc": "Selects every element that is the nth element of its parent", "text":"nth-of-type(n)"}, | ||
"only-of-type": {"desc": "Selects every element that is the only element of this type of its parent"}, | ||
"matches(selectors)": {"decs": "Selects every element that is matched by one or more selectors in the 'selectors' list"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add a 'text' field in the value with the insertion text as 'matches()'. Other wise user has to always delete selectors after hint selection.
@swmitra Fixed. Added |
swmitra
approved these changes
May 3, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@valtlai Good work. Waiting for more now... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pseudo-classes
–
:default
–
:dir()
–
:focus-within
–
:fullscreen
–
:indeterminate
–
:matches()
–
:placeholder-shown
.Add pseudo-element
::placeholder
.Fix alphabetical order, space around
:
.