-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update Source Code Pro and Source Sans Pro #12663
base: master
Are you sure you want to change the base?
Conversation
Could you try the /cc @le717 @peterflynn just in case |
Let's see what @peterflynn thinks about that, as he was probably the biggest opponent of the otf font. |
I'm still for switching to the |
My earlier comment about Source Code Pro bringing no visible changes was not exactly true - turned out I used another font, which I had forgotten about 🤐 So, here's both a gif and a diff showing the whole window. |
Thinking more, after looking other issues, I think this require a good amount of tests. |
Sorry, missed this PR completely. I am routing this request to people who can actually test the rendering using different character sets. |
Updates Source Code Pro to https://github.com/adobe-fonts/source-code-pro/releases/tag/2.030R-ro%2F1.050R-it
Updates Source Sans Pro to https://github.com/adobe-fonts/source-sans-pro/releases/tag/2.020R-ro%2F1.075R-it
In the editor area (that is, Source Code Pro), there is no visual change whatsoever, at least for my sample content (which is normal code using Roman letters).
In the file tree, there are some small visible changes. See #8985 (which is now superseded by this PR) for a long discussion about these changes.
Here's a gif outlining these visible changes:
And here's a diff highlight: