Update _shouldShowInTree to only hide specified hidden files. #1165
Conversation
ghost
assigned 
|
Assigned to me. Reviewing. |
| } | ||
|
|
||
| return true; | ||
| return [".git", ".svn", ".DS_Store", "Thumbs.db"].indexOf(entry.name) === -1; |
There was a problem hiding this comment.
This solution is good enough for now (or at least it's better than before). Our preferences stories haven't been refined enough, so I went ahead and captured the need for custom file filtering in the backlog. https://trello.com/c/OmPlSisf.
|
Review done. @TuckerWhitehouse be sure to sign the CLA before I merge this pull request http://dev.brackets.io/brackets-contributor-license-agreement.html. Also, if you haven't already, run the unit tests on this branch. In Brackets, Debug > Run Tests. |
|
Already signed the CLA and ran the unit tests, passed 100%. I know it's just a temporary solution, but it at least is a little more extensible than the current implementation. |
|
Can you try filling it out again? @adrocknaphobia is out at Google I/O, he'd normally handle CLA questions. I suspect the Github username field is case sensitive. |
|
Nevermind. It is case sensitive. I'll have @adrocknaphobia fix it. Merging now. |
Update _shouldShowInTree to only hide specified hidden files.
Solution for #1133