-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Latest source code pro with Russian / Cyrillic / Greek support. #11301
Conversation
Note: Look over here to see the changes and compare the old and new versions: 07c3de7 (Screenshots taken on a Windows 8.1, 1366x768 laptop) The new version looks bolder and appears to be more readable to me. |
+1 I too like the new look . |
@rawat11 If There are no significant defects apart from this, Can we go ahead with this integration ? |
@sprintr Another question. Are you seeing this with certain font sizes or are you seeing this in general with all the font sizes? |
@nethip It happen for (16px, 19px, 21px, 25px, 28px, 42px) etc as well, but seems bearable. with 13px it seems touching. |
@abose Yes, the new font is definitely more readable, our internal team is verifying it, will update once it's done. |
@sprintr Thanks for the screenshots. @rawat11 do we want to file a bug at https://github.com/adobe-fonts/source-code-pro |
@nethip On MAC, there is some issue with the font rendering, some of the characters are not clearly visible with the respect to the other characters on the same plane. On increasing the font size |
@nethip We already have a issue raised there, do you want me log another ? I can do that otherwise |
@rawat11 That's fine! Let us wait to hear from @pauldhunt on that. |
5db9b49
to
e4ba9f2
Compare
Reverted the font to TTF. Though I like the OTF rendering in windows better, Some of the character glyphs doesn't work well in windows[see https://github.com/adobe-fonts/source-code-pro/issues/98 for discussion]. |
@nethip The new fonts looks good to the linguist team. We can go ahead with the fonts |
Latest source code pro with Russian / Cyrillic / Greek support.
Thanks @rawat11 For the detailed tests. Merging. |
Latest source code pro with Russian / Cyrillic / Greek support.
these fonts now support the WGL4 character set.