Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Latest source code pro with Russian / Cyrillic / Greek support. #11301

Merged
merged 1 commit into from
Jun 30, 2015

Conversation

abose
Copy link
Contributor

@abose abose commented Jun 23, 2015

Latest source code pro with Russian / Cyrillic / Greek support.
these fonts now support the WGL4 character set.

@marcelgerber
Copy link
Contributor

Note: Look over here to see the changes and compare the old and new versions: 07c3de7 (Screenshots taken on a Windows 8.1, 1366x768 laptop)

The new version looks bolder and appears to be more readable to me.
I like it. :shipit:

@abose
Copy link
Contributor Author

abose commented Jun 24, 2015

+1 I too like the new look .

@abose
Copy link
Contributor Author

abose commented Jun 24, 2015

@rawat11 If There are no significant defects apart from this, Can we go ahead with this integration ?

@sprintr
Copy link
Contributor

sprintr commented Jun 24, 2015

After trying this out with my normal preferences (13px, "SourceCodePro-Medium"), I found that superscript dot of letter i doesn't have much distance from its bottom body and seems to be touching each other.

After:
after

Before:
before

@nethip
Copy link
Contributor

nethip commented Jun 24, 2015

@sprintr Good observation! We should watch out for these kind of changes which are subtle but might impact the readability of code in general.

@rawat11 Please test specifically on MAC as there seem to be lot of font rendering issues on MAC and I am sure you will find a jewel in there 😄

@nethip
Copy link
Contributor

nethip commented Jun 24, 2015

@sprintr Another question. Are you seeing this with certain font sizes or are you seeing this in general with all the font sizes?

@sprintr
Copy link
Contributor

sprintr commented Jun 24, 2015

@nethip It happen for (16px, 19px, 21px, 25px, 28px, 42px) etc as well, but seems bearable. with 13px it seems touching.

@sprintr
Copy link
Contributor

sprintr commented Jun 24, 2015

Using my color palette extension, to get a good view of the problem with i.

2015-06-25 02_25_30-c__users_aminullah_desktop_greenshot_after png test - brackets

@rawat11
Copy link

rawat11 commented Jun 25, 2015

@abose Yes, the new font is definitely more readable, our internal team is verifying it, will update once it's done.

@nethip
Copy link
Contributor

nethip commented Jun 25, 2015

@sprintr Thanks for the screenshots. @rawat11 do we want to file a bug at https://github.com/adobe-fonts/source-code-pro

@rawat11
Copy link

rawat11 commented Jun 25, 2015

@nethip On MAC, there is some issue with the font rendering, some of the characters are not clearly visible with the respect to the other characters on the same plane.
Also there visibility is increased once we increase the font size.

1

On increasing the font size

mac

And on windows the same data renders nicely
cyrillic

@nethip
Copy link
Contributor

nethip commented Jun 25, 2015

@rawat11 Thanks! Could you go ahead and update this with the above screenshots and the testing details.

@rawat11
Copy link

rawat11 commented Jun 25, 2015

@nethip We already have a issue raised there, do you want me log another ? I can do that otherwise

@nethip
Copy link
Contributor

nethip commented Jun 25, 2015

@rawat11 That's fine! Let us wait to hear from @pauldhunt on that.

@abose
Copy link
Contributor Author

abose commented Jun 25, 2015

Reverted the font to TTF. Though I like the OTF rendering in windows better, Some of the character glyphs doesn't work well in windows[see https://github.com/adobe-fonts/source-code-pro/issues/98 for discussion].

@rawat11
Copy link

rawat11 commented Jun 30, 2015

@nethip The new fonts looks good to the linguist team. We can go ahead with the fonts

@abose abose changed the title [review only-test in progress] Latest source code pro with Russian / Cyrillic / Greek support. Latest source code pro with Russian / Cyrillic / Greek support. Jun 30, 2015
abose added a commit that referenced this pull request Jun 30, 2015
Latest source code pro with Russian / Cyrillic / Greek support.
@abose abose merged commit e35f2a4 into master Jun 30, 2015
@abose abose deleted the abose/SourceCodeProNew branch June 30, 2015 07:38
@abose
Copy link
Contributor Author

abose commented Jun 30, 2015

Thanks @rawat11 For the detailed tests. Merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants