-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[MAC] Enabling back sub pixel antialiasing for code view #11235
Changes from all commits
1015223
698f52b
c7cafae
7a95c0a
74e7ff9
7e769b4
0582f1c
5efe7a8
faad138
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,18 +53,15 @@ html, body { | |
|
||
/* And make sure we get a pointer cursor even over text */ | ||
cursor: default; | ||
|
||
/* Turn off subpixel antialiasing on Mac since it flickers during animations. */ | ||
-webkit-font-smoothing: antialiased; | ||
|
||
// This is a hack to avoid flicker when animations (like inline editors) that use the GPU complete. | ||
// It seems that we have to put it here rather than on the animated element in order to prevent the | ||
// entire window from flashing. | ||
// See: http://stackoverflow.com/questions/3461441/prevent-flicker-on-webkit-transition-of-webkit-transform | ||
// Mac-only though, since this would turn off subpixel antialiasing (ClearType) on Windows | ||
|
||
&.platform-mac { | ||
-webkit-backface-visibility: hidden; | ||
backface-visibility: hidden; | ||
// Use gray scale antialiasing for UI. Code view editor-holder | ||
// overrides this to use subpixel antialiasing on Mac, which then | ||
// can be overridden by setting "fontSmoothing" preference to | ||
// "antialiased". Gray scale AA is used for UI parts which use | ||
// SourceSansPro font, which does't look good with subpixel AA, | ||
// especially on low resolution monitors. | ||
-webkit-font-smoothing: antialiased; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This setting applies to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes that is correct. The entire UI would have gray scale anti aliasing except for the code editor. Subpixel AA for the UI was not looking good. It exposed some artifacts which was making the entire editor look out of place. I will update the PR with my findings and PR, that will help understand the scenario. Thanks! |
||
} | ||
|
||
.dark, | ||
|
@@ -73,7 +70,9 @@ html, body { | |
} | ||
} | ||
|
||
|
||
.subpixel-aa{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why don't we just make it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I see now. Disregard that. |
||
-webkit-font-smoothing: subpixel-antialiased; | ||
} | ||
|
||
.resizing-container { | ||
position: absolute; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work right now, you need to add the
Strings.
namespace inmain-view.html
to the template vars there.But read my other comment before you do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an real good catch Marcel 👏