Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

"Install from URL" doesn't work any longer #9196

Closed
marcelgerber opened this issue Sep 22, 2014 · 5 comments · Fixed by #9226
Closed

"Install from URL" doesn't work any longer #9196

marcelgerber opened this issue Sep 22, 2014 · 5 comments · Fixed by #9226

Comments

@marcelgerber
Copy link
Contributor

  1. Open Extension Manager
  2. Click Install from URL in the footer
  3. Try to input something

Result:
The input field is disabled, you can't type in an URL. Works in Release 0.43, though.

@marcelgerber
Copy link
Contributor Author

Damn, git bisect points to my very own commit df0d86e. I'll provide a fix soon.

@marcelgerber
Copy link
Contributor Author

We should mark that issue Release 0.44 as it's a massive regression...
(@ingorichter?)

@ingorichter
Copy link
Contributor

I'll check it out tomorrow morning

@peterflynn
Copy link
Member

@marcelgerber Yep, agreed -- adding milestone.

@redmunds
Copy link
Contributor

Confirmed. Closing.

peterflynn added a commit that referenced this issue Oct 10, 2014
no-focus from dialog root to allow text selection. Change scope of key
listener so tabbing continues to work without needing to reintroduce
tabIndex on the dialog, since that triggers Bootstrap-modal problems (#9196).

Also: add an extra error logging line so that failed updates always log some
error details to the console. (I think this case seemed to come up in a bug
a while back, but couldn't remember which one).
peterflynn added a commit that referenced this issue Oct 21, 2014
…rouping

* origin/master: (182 commits)
  Fix unit test failure -- file-read wasn't always passing back correct error codes anymore. If the initial stat() fails (e.g. file doesn't exist or permission denied), we were double-converting the error code from brackets-shell format to FS impl API format, causing it to get mangled and treated as "Unknown."
  Limit document file sizes to 16MB on open
  fix definePreference
  auto-install extensions
  Updated .not-editor styling based on @TomMalbran's feedback.
  Added subtle border for dark menus.
  Pushing sidebar icons to the back of Working Files label when they overlap.
  Project dropdown toggle needs right margin.
  Making sure that the anchors in jstree will never show a hover state.
  Fix live dev highlight being out of place in edge cases
  Fix for #9545.
  Made unfocused pane look unfocused.
  Initial commit. Added necessary properties in order to override bootstrap styles. This branch is for #7887.
  Recognize Vagrantfile as ruby
  Replace HTML entity with literal dash in Getting Started
  Update strings.js
  Update strings.js
  Fix bug #9511 (Can't select text in Extension Manager anymore) - Remove no-focus from dialog root to allow text selection. Change scope of key listener so tabbing continues to work without needing to reintroduce tabIndex on the dialog, since that triggers Bootstrap-modal problems (#9196).
  corrected typo in 'bootstrapping'
  Working Performance Set Improvements
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants