Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Core][Quick Docs]: URL and CSS Property name tag on the left column in Quick Docs cannot be wrapped when resize the window. #5726

Closed
julieyuan opened this issue Oct 28, 2013 · 20 comments
Assignees

Comments

@julieyuan
Copy link

Steps:

  1. Launch Brackets and open a CSS file
  2. Put the cursor in a property name, like: text-shadow, word-wrap (sample file please refer to here)
  3. Press Cmd-K to open Quick Docs.
  4. Drag the right sidebar to the left.

Result:
The URL and property name tag are not wrapped and appears on the right column.

Expected:
They should be wrapped and only appears on the left column.

ENV: MAC10.8 and Win8.1 English OS
Build: 0.33.0-9858

Snapshots:
Please refer to snapshots for details:
11
22

@peterflynn
Copy link
Member

@julieyuan Has this always been the case (e.g. back in Sprint 24 when Quck Docs was introduced)? Or is it a more recent regression?

@julieyuan
Copy link
Author

@peterflynn I think this issue is caused by the change of webdocs. I checked it with Sprint 30, it not reproduces for the content is not the same. But it indeed reproduces in Sprint 32. Here is the snapshot with Sprint 30 for reference:
screen shot 2013-10-28 at 2 00 36 am

@RaymondLim
Copy link
Contributor

It was introduced when we added the close button to the inline editor. @larz0 can you try to fix it in the css?

@larz0
Copy link
Member

larz0 commented Oct 28, 2013

@RaymondLim yes I can take this one.

@ghost ghost assigned larz0 Oct 28, 2013
@larz0
Copy link
Member

larz0 commented Oct 28, 2013

@RaymondLim pull request is up.

@njx
Copy link

njx commented Oct 28, 2013

Marking low pri, fix in progress.

@RaymondLim
Copy link
Contributor

FBNC to @julieyuan

@ghost ghost assigned julieyuan Oct 29, 2013
@julieyuan
Copy link
Author

Thanks @larz0 for fixing this issue. Checked it with build 0.33.0-10187. These two properties above are fixed.Here is the snapshot for reference:
5726
For this issue, I have a little bit confusion. Is it possible that the URL is wrapped by word ? I mean, it is wrapped as:
css/
properties/
wrap
instead of :
cs
c/properties/word-
wrap
Anyway,the fix right now is already good enough 👍
If it could be wrapped by word and be fixed easily, it will be an improvement, but it is not necessary if it needs much effort.

There is another related issue.When I checked this issue, I found that anoter property box-shadow is not wrapped correctly with long string. Here is the snapshot for details:
capture decran 2013-10-29 a 7 02 22 pm

@RaymondLim or @larz0 , could you help to take a look?

@larz0
Copy link
Member

larz0 commented Oct 30, 2013

@RaymondLim new pull request is up.

@julieyuan
Copy link
Author

Please also note the property of background-color and background-image. Here is the snapshot with build 0.33.0-10191:
screen shot 2013-10-31 at 12 56 01 am

@larz0
Copy link
Member

larz0 commented Oct 31, 2013

Thanks @julieyuan this is fixed in #5755 (Breaking words for the entire column.)

screen shot 2013-10-31 at 12 16 20 pm

@marcelgerber
Copy link
Contributor

@larz0 Wouldn't it be better to use word-wrap: break-word; instead of word-break: break-all; as this breaks the words in a more normal way?

Currently:
image

With word-wrap:
image

And it also does it's job when there is such an situation as in your screen of background-color.

@larz0
Copy link
Member

larz0 commented Nov 3, 2013

Thanks @SAplayer I'll take a look. Not sure why the hyphens property isn't working.

@RaymondLim
Copy link
Contributor

@larz0
I did verify that @SAplayer 's change works for all the reported issues. And the hyphens property is also working for me. Are you saying it's not working with the change to word-wrap property?

@larz0
Copy link
Member

larz0 commented Nov 3, 2013

@RaymondLim I couldn't get hyphens to work for Background-Color using word-wrap: break-word

screen shot 2013-11-03 at 9 59 05 am

@RaymondLim
Copy link
Contributor

@larz0 That's correct behavior in your screenshot since your first column width is too narrow to fit background-, but it should break at hyphen if your column width is wider to fit more than background- as in the following screenshot.
quickdocbkgdcolor

@larz0
Copy link
Member

larz0 commented Nov 3, 2013

@RaymondLim the pull request is up #5835

@RaymondLim
Copy link
Contributor

@larz0 Sorry that I misunderstood you on hyphens property. I just tried it on Safari browser to see what it is used for. But again, it is not yet supported in Chrome and therefore never worked since your first version.

@marcelgerber
Copy link
Contributor

Thanks @larz0, looks good.

myaaghubi pushed a commit to myaaghubi/brackets that referenced this issue Nov 5, 2013
@julieyuan
Copy link
Author

Checked this issue with build 0.34.0-10270. It is fixed. Thanks a lot.
Closing it. Here are snapshots for reference:
background
box-shadow

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants