Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Needs two tries to rerun Find in Files after search with zero results #5699

Closed
peterflynn opened this issue Oct 25, 2013 · 7 comments · Fixed by #5793
Closed

Needs two tries to rerun Find in Files after search with zero results #5699

peterflynn opened this issue Oct 25, 2013 · 7 comments · Fixed by #5793
Assignees
@peterflynn
Labels
fixed but not closed
Milestone
Sprint 34

Comments

@peterflynn
Copy link
Member

  1. Right click a folder > Find in...
  2. Type some text that won't appear in the folder; hit Enter
  3. Wait until find bar field turns red (no results)
  4. Right click a folder > Find in...

Result:
Find bar disappears

Expected:
Search field is focused and text is selected (same as when you hit Cmd+F while Find is already open)
@ghost ghost assigned redmunds Oct 28, 2013
@njx
Copy link

njx commented Oct 28, 2013

Medium priority to @redmunds on the theory that it might be related to #5371.

@peterflynn
Copy link
Member Author

Almost positive #5371 is the reason, but I'd be inclined to call this a Low...

@redmunds
Copy link
Contributor

Nominating for Sprint 34.

@marcelgerber marcelgerber mentioned this issue Nov 2, 2013
Merged
redmunds added a commit that referenced this issue Nov 3, 2013
@redmunds
Merge pull request #5793 from SAPlayer/find-in-files-focus
70b2803 
Fix #5699: Set focus to input field when hitting Find In Files when it is already open
@ghost ghost assigned peterflynn Nov 3, 2013
@redmunds
Copy link
Contributor

redmunds commented Nov 3, 2013

FBNC back to @peterflynn

@peterflynn peterflynn reopened this Nov 5, 2013
@marcelgerber
Copy link
Contributor

@peterflynn Why had you reopened this?
Isn't the fix working, is there a situation where the bug still occurs?

@redmunds
Copy link
Contributor

redmunds commented Nov 5, 2013

@SAplayer The bug was auto-closed by github, when it should not have been. @peterflynn re-opened it until he has time to review it.

@peterflynn
Copy link
Member Author

Confirmed fixed

@core-ai-bot core-ai-bot mentioned this issue Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@peterflynn peterflynn

Labels
fixed but not closed
Projects
None yet
Milestone
Sprint 34
4 participants
@njx @redmunds @peterflynn @marcelgerber