-
Notifications
You must be signed in to change notification settings - Fork 7.6k
HTML tag highlight needs to be able to be overridden by find-match and selection background color. #5037
Comments
Another issue is that the tag-match highlights are invisible against the active-line highlight -- they appear to be using the exact same color. Tagging as high since editing HTML files feels pretty broken due to all this. |
@peterflynn I made a pull request for invisible braces match (#5034). Tag-match highlight should match the color we decide in that pull request. |
@larz0 try colors like this. with some alpha.
|
@sathyamoorthi ideally the tag highlight should go away like how active-line-highlight disappears when user starts to select text. |
@larz0 That doesn't fix the issue where it is invisible atop the active-line highlight, though. In the future it might not fix the Find highlighting either (it does for now, but only because Find highlighting uses selection under the hood -- which I suspect we're going to move away from). |
@larz0 this patch fixed your issues codemirror/codemirror5@22ea8d9 |
@sathyamoorthi that's awesome. Thanks for the heads up! |
Assigned to @larz0 tagging FBNC. Looks like it's fixed in master already. |
Looks good! Thanks for the heads up @jasonsanjose. |
To reproduce:
CC: @sathyamoorthi
The text was updated successfully, but these errors were encountered: