Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

HTML tag highlight needs to be able to be overridden by find-match and selection background color. #5037

Closed
larz0 opened this issue Sep 3, 2013 · 9 comments
Assignees
Milestone

Comments

@larz0
Copy link
Member

larz0 commented Sep 3, 2013

To reproduce:

  1. Paste <script type="text/javascript" src="js/bootstrap.min.js"></script> into HTML
  2. Select a part of the code that we just pasted, notice the lack of blue highlight
  3. Find "script" and notice that the find-match yellow highlight doesn't get applied

CC: @sathyamoorthi

@peterflynn
Copy link
Member

Another issue is that the tag-match highlights are invisible against the active-line highlight -- they appear to be using the exact same color.

Tagging as high since editing HTML files feels pretty broken due to all this.

@larz0
Copy link
Member Author

larz0 commented Sep 3, 2013

@peterflynn I made a pull request for invisible braces match (#5034). Tag-match highlight should match the color we decide in that pull request.

@sathyamoorthi
Copy link
Contributor

@larz0 try colors like this. with some alpha.

.CodeMirror-matchingtag { background: rgba(208, 208, 208, 0.5) }

@larz0
Copy link
Member Author

larz0 commented Sep 4, 2013

@sathyamoorthi ideally the tag highlight should go away like how active-line-highlight disappears when user starts to select text.

@peterflynn
Copy link
Member

@larz0 That doesn't fix the issue where it is invisible atop the active-line highlight, though. In the future it might not fix the Find highlighting either (it does for now, but only because Find highlighting uses selection under the hood -- which I suspect we're going to move away from).

@sathyamoorthi
Copy link
Contributor

@larz0 this patch fixed your issues codemirror/codemirror5@22ea8d9

@larz0
Copy link
Member Author

larz0 commented Sep 6, 2013

@sathyamoorthi that's awesome. Thanks for the heads up!

@ghost ghost assigned larz0 Sep 11, 2013
@jasonsanjose
Copy link
Member

Assigned to @larz0 tagging FBNC. Looks like it's fixed in master already.

@larz0
Copy link
Member Author

larz0 commented Sep 11, 2013

Looks good! Thanks for the heads up @jasonsanjose.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants