[CLOSED] HTML tag highlight needs to be able to be overridden by find-match and selection background color.

[core-ai-bot]

Issue by larz0
Tuesday Sep 03, 2013 at 21:56 GMT
Originally opened as adobe/brackets#5037

---

To reproduce:

1. Paste <script type="text/javascript" src="js/bootstrap.min.js"></script> into HTML
2. Select a part of the code that we just pasted, notice the lack of blue highlight
3. Find "script" and notice that the find-match yellow highlight doesn't get applied

CC:@sathyamoorthi

[core-ai-bot]

Comment by peterflynn
Tuesday Sep 03, 2013 at 22:19 GMT

---

Another issue is that the tag-match highlights are invisible against the active-line highlight -- they appear to be using the exact same color.

Tagging as high since editing HTML files feels pretty broken due to all this.

[core-ai-bot]

Comment by larz0
Tuesday Sep 03, 2013 at 22:53 GMT

---

@peterflynn I made a pull request for invisible braces match (#5034). Tag-match highlight should match the color we decide in that pull request.

[core-ai-bot]

Comment by sathyamoorthi
Wednesday Sep 04, 2013 at 02:30 GMT

---

@larz0 try colors like this. with some alpha.

.CodeMirror-matchingtag { background: rgba(208, 208, 208, 0.5) }

[core-ai-bot]

Comment by larz0
Wednesday Sep 04, 2013 at 04:15 GMT

---

@sathyamoorthi ideally the tag highlight should go away like how active-line-highlight disappears when user starts to select text.

[core-ai-bot]

Comment by peterflynn
Wednesday Sep 04, 2013 at 08:13 GMT

---

@larz0 That doesn't fix the issue where it is invisible atop the active-line highlight, though. In the future it might not fix the Find highlighting either (it does for now, but only because Find highlighting uses selection under the hood -- which I suspect we're going to move away from).

[core-ai-bot]

Comment by sathyamoorthi
Friday Sep 06, 2013 at 05:30 GMT

---

@larz0 this patch fixed your issues codemirror/codemirror5@22ea8d9

[core-ai-bot]

Comment by larz0
Friday Sep 06, 2013 at 05:40 GMT

---

@sathyamoorthi that's awesome. Thanks for the heads up!

[core-ai-bot]

Comment by jasonsanjose
Wednesday Sep 11, 2013 at 23:40 GMT

---

Assigned to@larz0 tagging FBNC. Looks like it's fixed in master already.

[core-ai-bot]

Comment by larz0
Wednesday Sep 11, 2013 at 23:44 GMT

---

Looks good! Thanks for the heads up@jasonsanjose.