Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Inserting new line right before tag that has an inline editor below it causes inline editor to close #368

Closed
tvoliter opened this issue Mar 1, 2012 · 3 comments

Comments

@tvoliter
Copy link
Contributor

tvoliter commented Mar 1, 2012

  1. Create a project with the following html and css files:
<div id="wrapper">
    <div id="header">
    </div>
</div>
#header {
    width: 980px;
    margin: 80px auto 0 auto;
    position: relative;
}
  1. In the html file click "header" on line Fleshed out overall UI layout #2 and bring up the inline editor
  2. Put the cursor right before "<div" on line Fleshed out overall UI layout #2 and press the enter key

Result:
The inline editor is closed.

Expected
Since the div tag is still intact the editor should remain open.

I found that many other types of edits that do work including:
a. inserting newline at the very beginning of line #2
b. inserting a newline in the middle of the div tag
c. inserting a newline anywhere above line #2

@njx
Copy link

njx commented Mar 13, 2012

Turns out this is a bug in the CodeMirror bookmark mechanism. Fixed in pull request https://github.com/adobe/CodeMirror2/pull/35 -- once that's pulled I'll submit it to Marijn as well since it's easily separable from our other CM changes.

@njx
Copy link

njx commented Mar 13, 2012

To @tvoliter as FBNC. Please make sure to pull the latest CodeMirror.

@tvoliter
Copy link
Contributor Author

fix verified. Closing.

gideonthomas pushed a commit to gideonthomas/brackets that referenced this issue Apr 13, 2017
* FileViewController.js modified for fix 368

* FileViewController.js modified for fix 368
gideonthomas pushed a commit to gideonthomas/brackets that referenced this issue Apr 19, 2017
* FileViewController.js modified for fix 368

* FileViewController.js modified for fix 368
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants