Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Getting started instructions no longer work #2811

Closed
peterflynn opened this issue Feb 8, 2013 · 5 comments
Closed

Getting started instructions no longer work #2811

peterflynn opened this issue Feb 8, 2013 · 5 comments

Comments

@peterflynn
Copy link
Member

@GarthDB: It turns out the CSS changes in #2799 "broke" the Getting Started instructions. The instructions specifically refer to the border & background that were removed:

Now, place your cursor on the tag above and use Cmd/Ctrl + E to open up the defined CSS rules. Try changing the size of the border from 1px to 10px or change the background color from "dimgray" to "hotpink".

We're past string freeze, so unfortunately we can't modify that text anymore. We'll have to put the border/bg back (and presumably remove the dropshadow that was added in the image) for now. Feel free to file a spinoff bug if you think we should try to do something better next sprint (tweaking an image border always felt weird as an example use case to me).

We'll have to make this fix in EC too.

@peterflynn
Copy link
Member Author

Uh-oh -- looks like this is spilling into other community locales already (#2800, #2801). Bumping to High...

@GarthDB
Copy link
Member

GarthDB commented Feb 8, 2013

That's fine

Sent from my iPhone

On Feb 7, 2013, at 8:34 PM, "Peter Flynn" <[email protected]mailto:[email protected]> wrote:

@GarthDBhttps://github.com/GarthDB: It turns out the CSS changes in #2799#2799 "broke" the Getting Started instructions. The instructions specifically refer to the border & background that were removed:

Now, place your cursor on the tag above and use Cmd/Ctrl + E to open up the defined CSS rules. Try changing the size of the border from 1px to 10px or change the background color from "dimgray" to "hotpink".

We're past string freeze, so unfortunately we can't modify that text anymore. We'll have to put the border/bg back (and presumably remove the dropshadow that was added in the image) for now. Feel free to file a spinoff bug if you think we should try to do something better next sprint (tweaking an image border always felt weird as an example use case to me).

We'll have to make this fix in EC too.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2811.

@pthiess
Copy link
Contributor

pthiess commented Feb 8, 2013

Reviewed. Sorry saw this too late in the de locale.

@njx
Copy link

njx commented Feb 8, 2013

FBNC to @peterflynn. Fixed in both en and de; left a comment on the es pull request to update the CSS there.

@ghost ghost assigned pthiess and peterflynn Feb 8, 2013
@peterflynn
Copy link
Member Author

Confirmed fixed for Brackets (en & de) and EC (en). Note that EC fr still has an old screenshot (HTML menus & no dropshadow) and old CSS styles (less padding, no rounded corners).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants