Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Don't need to maintain _currentFilePath in FileCommandHandlers #271

Closed
njx opened this issue Feb 15, 2012 · 2 comments
Closed

Don't need to maintain _currentFilePath in FileCommandHandlers #271

njx opened this issue Feb 15, 2012 · 2 comments

Comments

@njx
Copy link

njx commented Feb 15, 2012

We currently maintain a _currentFilePath member in FileCommandHandlers. Instead, we should just use getCurrentDocument().file.fullPath.

peterflynn added a commit that referenced this issue Feb 21, 2012
…se the

FileEntry from DocumentManager.getCurrentDocument() instead.
redmunds added a commit that referenced this issue Feb 22, 2012
Fix small refactoring issue #271 (Remove FileCommandHandlers._currentFilePath)
@peterflynn
Copy link
Member

Sending over to @njx now that this is merged in

@njx
Copy link
Author

njx commented Feb 22, 2012

Closing

@njx njx closed this as completed Feb 22, 2012
peterflynn added a commit that referenced this issue Feb 23, 2012
* origin/master:
  Update CodeMirror SHA
  updates from code review
  Respond to code review feedback
  final code cleanup, commenting, and functionality
  Fix refactoring issue #271: Remove unneeded _currentFilePath state, use the FileEntry from DocumentManager.getCurrentDocument() instead.
  Update unit tests to be more readable and add a test for when the closing quote of the attr value is typed
  initial pass at code hint triggers
  initial work to find an attribute name for code hinting

Conflicts:
	test/SpecRunner.js
iwehrman pushed a commit to iwehrman/brackets that referenced this issue Sep 11, 2013
[Kuler] Fix the two failing unit tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants