Merge pull request #13269 from thehogfather/thehogfather/issue-13264-…

…save-fold-states-error Addresses #13264 where setting `saveFoldStates` preference to false caused folding problems
adobe · Apr 7, 2017 · f9afa59 · f9afa59
2 parents 0442881 + 2d317ed
commit f9afa59
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/extensions/default/CodeFolding/main.js b/src/extensions/default/CodeFolding/main.js
@@ -117,13 +117,19 @@ define(function (require, exports, module) {
         }
 
         var saveFolds = prefs.getSetting("saveFoldStates");
+
         if (!editor || !saveFolds) {
+            if (editor) {
+                editor._codeMirror._lineFolds = editor._codeMirror._lineFolds || {};
+            }
             return;
         }
-        var viewState = ViewStateManager.getViewState(editor.document.file);
+                
         var cm = editor._codeMirror;
+        var viewState = ViewStateManager.getViewState(editor.document.file);
         var path = editor.document.file.fullPath;
         var folds = cm._lineFolds || prefs.getFolds(path) || {};
+
         //separate out selection folds from non-selection folds
         var nonSelectionFolds = {}, selectionFolds = {}, range;
         Object.keys(folds).forEach(function (line) {

diff --git a/src/extensions/default/CodeFolding/unittests.js b/src/extensions/default/CodeFolding/unittests.js
@@ -399,6 +399,14 @@ define(function (require, exports, module) {
                             var marks = getEditorFoldMarks();
                             expect(marks.length).toEqual(0);
                         });
+
+                        runs(function () {
+                            var lineNumbers = foldableLines;
+                            var marks = getGutterFoldMarks();
+                            var gutterNumbers = marks.filter(filterOpen)
+                                .map(getLineNumber);
+                            expect(gutterNumbers).toEqual(toZeroIndex(lineNumbers));
+                        });
                     });
 
                     it("can set the minimum fold size", function () {