Merge pull request #3143 from TomMalbran/tom/jslint-refactor

Fix #3094: Refactor JSLint into an extension

.gitmodules

@@ -4,9 +4,6 @@
 [submodule "src/thirdparty/path-utils"]
 	path = src/thirdparty/path-utils
 	url = https://github.com/jblas/path-utils.git
-[submodule "src/thirdparty/jslint"]
-	path = src/thirdparty/jslint
-	url = https://github.com/douglascrockford/JSLint.git
 [submodule "src/thirdparty/smart-auto-complete"]
 	path = src/thirdparty/smart-auto-complete
 	url = https://github.com/laktek/jQuery-Smart-Auto-Complete.git

NOTICE

@@ -44,7 +44,7 @@ respective licenses below.
     Released under the MIT, BSD, and GPL Licenses.
 
 
- - JSLint - ./src/thirdparty/jslint
+ - JSLint - ./src/extensions/default/JSLint/thirdparty/jslint
 
     Copyright (c) 2002 Douglas Crockford  (www.JSLint.com)
 

src/base-config/keyboard.json

@@ -201,15 +201,6 @@
     "navigate.gotoDefinition":  [
         "Ctrl-T"
     ],
-    "navigate.gotoJSLintError":  [
-        {
-            "key": "F8"
-        },
-        {
-            "key": "Cmd-'",
-            "platform": "mac"
-        }
-    ],
     "navigate.nextDoc":  [
         {
             "key": "Ctrl-Tab"

src/brackets.config.json

@@ -4,7 +4,6 @@
         "app_title"         : "Brackets",
         "app_name_about"    : "Brackets",
         "about_icon"        : "styles/images/brackets_icon.svg",
-        "enable_jslint"     : true,
         "update_info_url"   : "http://dev.brackets.io/updates/stable/",
         "how_to_use_url"    : "https://github.com/adobe/brackets/wiki/How-to-Use-Brackets",
         "forum_url"         : "https://groups.google.com/forum/?fromgroups#!forum/brackets-dev",

src/brackets.js

@@ -74,7 +74,6 @@ define(function (require, exports, module) {
         Commands                = require("command/Commands"),
         CommandManager          = require("command/CommandManager"),
         CodeHintManager         = require("editor/CodeHintManager"),
-        JSLintUtils             = require("language/JSLintUtils"),
         PerfUtils               = require("utils/PerfUtils"),
         FileIndexManager        = require("project/FileIndexManager"),
         QuickOpen               = require("search/QuickOpen"),
@@ -130,7 +129,6 @@ define(function (require, exports, module) {
             EditorManager           : EditorManager,
             Commands                : Commands,
             WorkingSetView          : WorkingSetView,
-            JSLintUtils             : JSLintUtils,
             PerfUtils               : PerfUtils,
             JSUtils                 : JSUtils,
             CommandManager          : CommandManager,

src/command/Commands.js

@@ -84,7 +84,6 @@ define(function (require, exports, module) {
     exports.TOGGLE_LINE_NUMBERS         = "view.toggleLineNumbers";
     exports.TOGGLE_ACTIVE_LINE          = "view.toggleActiveLine";
     exports.TOGGLE_WORD_WRAP            = "view.toggleWordWrap";
-    exports.TOGGLE_JSLINT               = "debug.jslint";
     exports.SORT_WORKINGSET_BY_ADDED    = "view.sortWorkingSetByAdded";
     exports.SORT_WORKINGSET_BY_NAME     = "view.sortWorkingSetByName";
     exports.SORT_WORKINGSET_BY_TYPE     = "view.sortWorkingSetByType";
@@ -96,7 +95,6 @@ define(function (require, exports, module) {
     exports.NAVIGATE_SHOW_IN_FILE_TREE  = "navigate.showInFileTree";
     exports.NAVIGATE_QUICK_OPEN         = "navigate.quickOpen";
     exports.NAVIGATE_GOTO_DEFINITION    = "navigate.gotoDefinition";
-    exports.NAVIGATE_GOTO_JSLINT_ERROR  = "navigate.gotoJSLintError";
     exports.NAVIGATE_GOTO_LINE          = "navigate.gotoLine";
     exports.TOGGLE_QUICK_EDIT           = "navigate.toggleQuickEdit";
     exports.QUICK_EDIT_NEXT_MATCH       = "navigate.nextMatch";

src/command/DefaultMenus.js

@@ -113,18 +113,14 @@ define(function (require, exports, module) {
         menu.addMenuItem(Commands.TOGGLE_ACTIVE_LINE);
         menu.addMenuItem(Commands.TOGGLE_LINE_NUMBERS);
         menu.addMenuItem(Commands.TOGGLE_WORD_WRAP);
-        menu.addMenuDivider();
-        menu.addMenuItem(Commands.TOGGLE_JSLINT);
 
         /*
          * Navigate menu
          */
         menu = Menus.addMenu(Strings.NAVIGATE_MENU, Menus.AppMenuBar.NAVIGATE_MENU);
         menu.addMenuItem(Commands.NAVIGATE_QUICK_OPEN);
         menu.addMenuItem(Commands.NAVIGATE_GOTO_LINE);
-
         menu.addMenuItem(Commands.NAVIGATE_GOTO_DEFINITION);
-        menu.addMenuItem(Commands.NAVIGATE_GOTO_JSLINT_ERROR);
         menu.addMenuDivider();
         menu.addMenuItem(Commands.NAVIGATE_NEXT_DOC);
         menu.addMenuItem(Commands.NAVIGATE_PREV_DOC);

src/config.json

@@ -3,7 +3,6 @@
         "app_title": "Brackets",
         "app_name_about": "Brackets",
         "about_icon": "styles/images/brackets_icon.svg",
-        "enable_jslint": true,
         "update_info_url": "http://dev.brackets.io/updates/stable/",
         "how_to_use_url": "https://github.com/adobe/brackets/wiki/How-to-Use-Brackets",
         "forum_url": "https://groups.google.com/forum/?fromgroups#!forum/brackets-dev",

src/extensions/default/JSLint/htmlContent/bottom-panel.html

@@ -0,0 +1,6 @@
+<div id="jslint-results" class="bottom-panel vert-resizable top-resizer no-focus">
+    <div class="toolbar simple-toolbar-layout">
+        <div class="title">{{JSLINT_ERRORS}}</div>
+    </div>
+    <div class="table-container resizable-content"></div>
+</div>

src/extensions/default/JSLint/htmlContent/results-table.html

@@ -0,0 +1,11 @@
+<table class="zebra-striped condensed-table">
+    <tbody>
+        {{#reportList}}
+        <tr>
+            <td class="line" data-character="{{character}}">{{line}}</td>
+            <td>{{reason}}</td>
+            <td>{{evidence}}</td>
+        </tr>
+        {{/reportList}}
+    </tbody>
+</table>

src/extensions/default/JSLint/jslint.css

@@ -0,0 +1,14 @@
+.jslint-disabled {
+    font-size: 1em;
+    color: #808080;
+}
+
+.jslint-errors {
+    font-size: 1em;
+    color: #dc322f;
+}
+
+.jslint-valid {
+    font-size: 1em;
+    color: #FFC81C;
+}

src/extensions/default/JSLint/keyboard.json

@@ -0,0 +1,11 @@
+{
+    "gotoFirstError":  [
+        {
+            "key": "F8"
+        },
+        {
+            "key": "Cmd-'",
+            "platform": "mac"
+        }
+    ]
+}