Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Forcefully disabling renderer accesibility #660

Merged
merged 4 commits into from
Oct 16, 2018
Merged

Conversation

nethip
Copy link
Contributor

@nethip nethip commented Oct 15, 2018

Windows update KB4343909 is leading to performance issues on some systems. This is because of accessiblity renderer tree getting created wrongly. So disabling this for now.

Thanks to @katoken-0215 for pointing this out.

@abhijitapte @swmitra Could you please review this?

…ormance issues with Windows update KB4343909
@nethip
Copy link
Contributor Author

nethip commented Oct 15, 2018

Fixes adobe/brackets#14515

…ter the user has passed on --force-renderer-accessibility or --enable-renderer-accessibility
Copy link
Collaborator

@swmitra swmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as you have already addressed selectively applying the flag. I will leave to the other reviewers now.

@vickramdhawal vickramdhawal merged commit 651b74b into master Oct 16, 2018
nethip added a commit that referenced this pull request Oct 16, 2018
* Forcefully disabling renderer accesibility as this is leading to performance issues with Windows update  KB4343909

* Conditionally adding disable-renderer-accessibility flag based on wheter the user has passed on --force-renderer-accessibility or --enable-renderer-accessibility

* Code cleanup and fixed documentation.

* Restricting the accessibility option only to Windows.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants