-
Notifications
You must be signed in to change notification settings - Fork 611
Support Auto Hide Task Bars on Windows #474
Conversation
@redmunds squashed and ready for merging. Thanks for the review! |
rect.bottom = rect.top + ::GetSystemMetrics(SM_CYSMICON); | ||
rect.right = rect.left + ::GetSystemMetrics(SM_CXSMICON); | ||
|
||
AdjustRectForAutoHideBars(&rect); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still seeing this line indented with spaces and the rest of the function is indented with Tabs. I know there's a mix of spaces vs tabs in code base, and even in some files, but I think it should at least be consistent in each function/method.
Sorry, for already saying it was ok to squash, but I realized that I didn't try all of the testing recommendations and I now notice a nasty bug:
Results UPDATE: This seems to be related to my secondary monitor setup (it's above primary). If I move secondary monitor to the right of primary and problem goes away. See screen shot for my setup: Primary monitor resolution is 1920x1200 |
@JeffryBooher I fixed the whitespace: 10e1378 |
Merging. |
Support Auto Hide Task Bars on Windows
@redmunds thanks for the review! |
Support Auto Hide Task Bars on Windows
This is for: adobe/brackets#7555
This replaces: #471
Place the task bar on:
Test with both auto hide and always visible.
This should be checked on Multiple Monitors as a fair amount of work went in to finding the right solution for multiple monitors.
You will notice a 1px area between the app and the taskbar. This is the taskbar and typical of all apps to give the taskbar an edge to grab. It IS more apparent with a dark border which gives the 1px line a little more contrast and makes it more visible.