This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Fix the internal server error #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dangoor There was an issue 2 weeks ago and this little change fixed it. I have applied those changes on the production machine, but haven't yet created the PR. |
|
Merged, since this is already running on production for more than a month. |
ingorichter
added a commit
that referenced
this pull request
Aug 6, 2014
Fix the internal server error
|
Ahh, sorry for not getting to this. It's a tiny change and perfectly sensible. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no bug filed for this issue, but this error happened after we deployed the latest version of the registry with the download data tracking feature.
The order of statements is important for passport, otherwise user couldn't authenticate with github and the server returned with a 500 internal server error.