Fixed an error that occurred when default content items were rendered via applyPropositions #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterworks
approved these changes
Oct 24, 2024
jonsnyder
approved these changes
Oct 24, 2024
| @@ -31,7 +31,7 @@ export default ({ logger, options }) => { | |||
| objectOf({ | |||
| id: string().required(), | |||
| schema: string().required(), | |||
| data: anything().required(), | |||
| data: objectOf(anything()), | |||
There was a problem hiding this comment.
I think you need to do objectOf({}). But why change data to have to be an object?. It seems you could just remove this line entirely and allow data to be set or not.
jonsnyder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue appeared after this PR has been released.
default-content-itemschemas items do not haveitem.data, thus this was leading into validation error and propositions were never applied. Customers do not know whendefault-content-itemis returned, which was breaking their implementation and their could not see the impressions. This is a critical issue because it impacts all the customers and can affect any other activities not only those that havedefault-content-item.Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: