Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Alloy Prod Upstreams Workflow #1159

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Refactor Alloy Prod Upstreams Workflow #1159

merged 7 commits into from
Sep 5, 2024

Conversation

shammowla
Copy link
Collaborator

  1. Kept the edgeBasePath input in the workflow_dispatch event for manual triggering.
  2. Removed EDGE_BASE_PATH from the global env section to avoid conflicts.
  3. Updated the saucelabs/saucectl-run-action step to use the input edgeBasePath.
  4. Aligned the structure with the main prod workflow for consistency.
  5. Added error handling and Slack notifications for test failures.

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

metadata:
name: Alloy SDK Prod ee
rootDir: ./
env:
ALLOY_ENV: prod
EDGE_BASE_PATH: ee
EDGE_BASE_PATH: ${EDGE_BASE_PATH:-ee}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to add a "-" here before "ee"?

@carterworks
Copy link
Contributor

carterworks commented Aug 16, 2024

  1. Address Jon's comment about the extra "-"
  2. The PR description mentions "Added error
    handling and Slack notifications for test failures", but I don't see anything that reflects that in the code. Where is it?

I know the Slack notifications in #alloy-ci, as it is right now, are supposed to show a bunch of info, but none of that comes through—notice how all the info at the beginning of the message is blank.

image

@shammowla shammowla merged commit 4b2196d into main Sep 5, 2024
4 of 5 checks passed
@shammowla shammowla deleted the edgebase-workflow branch September 5, 2024 17:47
@jonsnyder jonsnyder added the ignore-for-release Do not include this PR in release notes label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants