Update dependencies. (#1228)

* Update dependencies. * Update ESLint. * Add copyright. * Remove bundlesize. * Update vitest. * Fix lintint error.
adobe · Jan 23, 2025 · 00a2b23 · 00a2b23
1 parent d1582d1
commit 00a2b23
Show file tree

Hide file tree

Showing 29 changed files with 1,700 additions and 2,909 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -64,62 +64,56 @@
   },
   "author": "Adobe Inc.",
   "license": "Apache-2.0",
-  "bundlesize": [
-    {
-      "path": "./dist/alloy.min.js"
-    }
-  ],
   "dependencies": {
-    "@adobe/aep-rules-engine": "^2.0.2",
+    "@adobe/aep-rules-engine": "^2.0.3",
     "@adobe/reactor-cookie": "^1.1.0",
     "@adobe/reactor-load-script": "^1.1.1",
     "@adobe/reactor-object-assign": "^2.0.0",
     "@adobe/reactor-query-string": "^2.0.0",
     "@babel/core": "^7.26.0",
-    "@babel/eslint-parser": "^7.25.9",
+    "@babel/eslint-parser": "^7.26.5",
     "@babel/plugin-transform-template-literals": "^7.25.9",
     "@babel/preset-env": "^7.26.0",
-    "@inquirer/prompts": "^7.0.1",
+    "@inquirer/prompts": "^7.2.3",
     "@rollup/plugin-babel": "^6.0.4",
-    "@rollup/plugin-commonjs": "^28.0.1",
-    "@rollup/plugin-node-resolve": "^15.3.0",
+    "@rollup/plugin-commonjs": "^28.0.2",
+    "@rollup/plugin-node-resolve": "^16.0.0",
     "@rollup/plugin-terser": "^0.4.4",
-    "commander": "^12.1.0",
+    "commander": "^13.1.0",
     "css.escape": "^1.5.1",
     "js-cookie": "3.0.5",
     "parse-uri": "^1.0.9",
-    "rollup": "^4.24.4",
+    "rollup": "^4.31.0",
     "rollup-plugin-license": "^3.5.3",
-    "uuid": "^11.0.2"
+    "uuid": "^11.0.5"
   },
   "devDependencies": {
     "@adobe/alloy": "^2.25.0-beta.0",
-    "@babel/cli": "^7.25.9",
+    "@babel/cli": "^7.26.4",
     "@babel/plugin-transform-runtime": "^7.25.9",
-    "@eslint/js": "^9.14.0",
-    "@octokit/rest": "^21.0.2",
-    "@vitest/browser": "^2.1.8",
-    "@vitest/coverage-v8": "^2.1.8",
-    "bundlesize": "^0.18.2",
-    "chalk": "^5.3.0",
-    "concurrently": "^9.1.0",
+    "@eslint/js": "^9.18.0",
+    "@octokit/rest": "^21.1.0",
+    "@vitest/browser": "^3.0.3",
+    "@vitest/coverage-v8": "^3.0.3",
+    "chalk": "^5.4.1",
+    "concurrently": "^9.1.2",
     "date-fns": "^4.1.0",
-    "dotenv": "^16.4.5",
-    "eslint": "^8.57.0",
+    "dotenv": "^16.4.7",
+    "eslint": "^9.18.0",
     "eslint-config-airbnb-base": "^15.0.0",
-    "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-ban": "^1.6.0",
+    "eslint-config-prettier": "^10.0.1",
+    "eslint-plugin-ban": "^2.0.0",
     "eslint-plugin-import": "^2.31.0",
-    "eslint-plugin-prettier": "^5.2.1",
+    "eslint-plugin-prettier": "^5.2.3",
     "eslint-plugin-testcafe": "^0.2.1",
-    "glob": "^11.0.0",
-    "globals": "^15.12.0",
+    "glob": "^11.0.1",
+    "globals": "^15.14.0",
     "handlebars": "^4.7.8",
-    "happy-dom": "^15.11.1",
-    "husky": "^9.1.6",
-    "lint-staged": "^15.2.10",
+    "happy-dom": "^16.7.2",
+    "husky": "^9.1.7",
+    "lint-staged": "^15.4.1",
     "playwright": "^1.49.1",
-    "prettier": "^3.3.3",
+    "prettier": "^3.4.2",
     "read-cache": "^1.0.0",
     "recursive-readdir": "^2.2.3",
     "request": "^2.88.2",
@@ -128,14 +122,17 @@
     "rollup-plugin-istanbul": "^5.0.0",
     "semver": "^7.6.3",
     "staged-git-files": "^1.3.0",
-    "start-server-and-test": "^2.0.8",
-    "testcafe": "^3.7.0",
+    "start-server-and-test": "^2.0.10",
+    "testcafe": "^3.7.1",
     "testcafe-reporter-junit": "^3.0.2",
     "url-exists-nodejs": "^0.2.4",
     "url-parse": "^1.5.10",
-    "vitest": "^2.1.4"
+    "vitest": "^3.0.3"
   },
   "optionalDependencies": {
-    "@rollup/rollup-linux-x64-gnu": "^4.24.4"
+    "@rollup/rollup-linux-x64-gnu": "^4.31.0"
+  },
+  "overrides": {
+    "eslint": "^9.18.0"
   }
 }
diff --git a/scripts/helpers/publishToNpm.js b/scripts/helpers/publishToNpm.js
@@ -15,7 +15,7 @@ const publishToNpm = async ({ exec, execSync, logger, npmTag, version }) => {
     publishVersionJson = execSync(
       `npm view @adobe/alloy@${version} version --json`,
     ).toString();
-  } catch (e) {
+  } catch {
     // the error is already printed to stdErr
   }
   if (publishVersionJson !== "") {

diff --git a/scripts/specs/exec.spec.js b/scripts/specs/exec.spec.js
@@ -40,7 +40,7 @@ describe("exec", () => {
     try {
       await exec("bad exit", "exit 42", { outputStream });
       fail();
-    } catch (e) {
+    } catch {
       const result = getResult();
       expect(result).toMatch(/exited with code 42/);
     }
@@ -50,7 +50,7 @@ describe("exec", () => {
     try {
       await exec("bad exit", "exit 42", { outputStream });
       fail();
-    } catch (e) {
+    } catch {
       const result = getResult();
       expect(result).toMatch(/bad exit/);
     }

diff --git a/scripts/testConvert.js b/scripts/testConvert.js
@@ -308,8 +308,8 @@ for (let fileIndex = start; fileIndex < f.length; fileIndex += 1) {
                           ),
                         ),
                       );
-                    } catch (e) {
-                      // sss
+                    } catch {
+                      // Catch all errors.
                     }
                   }
                 }

diff --git a/src/components/Personalization/createComponent.js b/src/components/Personalization/createComponent.js
@@ -91,7 +91,6 @@ export default ({
             onResponse,
           });
         } else if (personalizationDetails.shouldUseCachedData()) {
-          // eslint-disable-next-line consistent-return
           decisionsMetaPromises.push(
             viewChangeHandler({
               personalizationDetails,

diff --git a/src/components/Personalization/createInteractionStorage.js b/src/components/Personalization/createInteractionStorage.js
@@ -46,7 +46,6 @@ export default () => {
     notification,
     interactId,
   ) => {
-    // eslint-disable-next-line no-param-reassign
     interactId = parseInt(interactId, 10);
 
     if (!clickMetaStorage[interactId]) {

diff --git a/src/components/RulesEngine/createEvaluableRulesetPayload.js b/src/components/RulesEngine/createEvaluableRulesetPayload.js
@@ -39,7 +39,7 @@ const isRulesetItem = (item) => {
       Object.prototype.hasOwnProperty.call(content, "version") &&
       Object.prototype.hasOwnProperty.call(content, "rules")
     );
-  } catch (error) {
+  } catch {
     return false;
   }
 };

diff --git a/src/components/RulesEngine/utils.js b/src/components/RulesEngine/utils.js
@@ -19,7 +19,7 @@ export const createRestoreStorage = (storage, storageKey) => {
 
     try {
       return JSON.parse(stored);
-    } catch (e) {
+    } catch {
       return defaultValue;
     }
   };

diff --git a/src/core/buildAndValidateConfig.js b/src/core/buildAndValidateConfig.js
@@ -93,7 +93,7 @@ export default ({
   );
   setDebugEnabled(config.debugEnabled, { fromConfig: true });
   queuedLogger.flush();
-  // eslint-disable-next-line no-underscore-dangle
+
   const extraParams = buildAllOnInstanceConfiguredExtraParams(
     config,
     logger,

diff --git a/src/core/edgeNetwork/injectExtractEdgeInfo.js b/src/core/edgeNetwork/injectExtractEdgeInfo.js
@@ -20,7 +20,7 @@ export default ({ logger }) =>
           if (!Number.isNaN(regionId)) {
             return { regionId };
           }
-        } catch (e) {
+        } catch {
           // No need to do anything. The log statement below will log an error
         }
       }

diff --git a/src/core/network/injectSendNetworkRequest.js b/src/core/network/injectSendNetworkRequest.js
@@ -65,7 +65,7 @@ export default ({
 
         try {
           parsedBody = JSON.parse(response.body);
-        } catch (e) {
+        } catch {
           // Non-JSON. Something went wrong.
         }
 

diff --git a/src/utils/injectStorage.js b/src/utils/injectStorage.js
@@ -25,7 +25,7 @@ const getStorageByType = (context, storageType, namespace) => {
     getItem(name) {
       try {
         return context[storageType].getItem(namespace + name);
-      } catch (e) {
+      } catch {
         return null;
       }
     },
@@ -39,7 +39,7 @@ const getStorageByType = (context, storageType, namespace) => {
       try {
         context[storageType].setItem(namespace + name, value);
         return true;
-      } catch (e) {
+      } catch {
         return false;
       }
     },
@@ -54,7 +54,7 @@ const getStorageByType = (context, storageType, namespace) => {
           }
         });
         return true;
-      } catch (e) {
+      } catch {
         return false;
       }
     },

diff --git a/src/utils/isValidRegExp.js b/src/utils/isValidRegExp.js
@@ -18,7 +18,7 @@ governing permissions and limitations under the License.
 export default (value) => {
   try {
     return RegExp(value) !== null;
-  } catch (e) {
+  } catch {
     return false;
   }
 };
diff --git a/src/utils/parseUrl.js b/src/utils/parseUrl.js
@@ -46,7 +46,6 @@ const parseDomainBasic = (host) => {
 
 const parseUrl = (url, parseDomain = parseDomainBasic) => {
   if (!isString(url)) {
-    // eslint-disable-next-line no-param-reassign
     url = "";
   }
   const parsed = parseUri(url) || {};

diff --git a/src/utils/updateErrorMessage.js b/src/utils/updateErrorMessage.js
@@ -13,7 +13,7 @@ governing permissions and limitations under the License.
 export default ({ error, message }) => {
   try {
     error.message = message;
-  } catch (e) {
+  } catch {
     // We'll set a new message when we can, but some errors, like DOMException,
     // have a read-only message property, which limits our options.
   }

diff --git a/src/utils/validation/createAnyOfValidator.js b/src/utils/validation/createAnyOfValidator.js
@@ -18,7 +18,7 @@ export default (validators, message) =>
       try {
         newValue = validator.call(this, value, path);
         return true;
-      } catch (e) {
+      } catch {
         return false;
       }
     });

diff --git a/test/functional/helpers/assertions/index.js b/test/functional/helpers/assertions/index.js
@@ -1,4 +1,13 @@
-/* eslint-disable import/prefer-default-export */
+/*
+Copyright 2025 Adobe. All rights reserved.
+This file is licensed to you under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License. You may obtain a copy
+of the License at http://www.apache.org/licenses/LICENSE-2.0
 
+Unless required by applicable law or agreed to in writing, software distributed under
+the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
+OF ANY KIND, either express or implied. See the License for the specific language
+governing permissions and limitations under the License.
+*/
 // Please keep in alphabetical order.
 export { default as responseStatus } from "./responseStatus.js";
diff --git a/test/functional/helpers/cookies.js b/test/functional/helpers/cookies.js
@@ -39,7 +39,7 @@ export default {
       .reduce((a, b) => {
         try {
           a[b[0]] = JSON.parse(b[1]);
-        } catch (e) {
+        } catch {
           a[b[0]] = b[1];
         }
         return a;

diff --git a/test/functional/helpers/createFixture/clientScripts.js b/test/functional/helpers/createFixture/clientScripts.js
@@ -65,7 +65,7 @@ const getProdNpmLibraryCode = () => readCache.sync(prodNpmLibraryPath, "utf8");
 
 export const injectInlineScript = ClientFunction((code) => {
   const scriptElement = document.createElement("script");
-  // eslint-disable-next-line no-undef
+
   scriptElement.innerHTML = code;
   document.getElementsByTagName("head")[0].appendChild(scriptElement);
 });

diff --git a/test/functional/specs/Data Collector/C81181.js b/test/functional/specs/Data Collector/C81181.js
@@ -189,7 +189,6 @@ test("Test C81181: Verify that onBeforeLinkClickSend augments a request", async
     clickCollectionEnabled,
     clickCollectionEventGroupingDisabled,
     {
-      // eslint-disable-next-line consistent-return
       onBeforeLinkClickSend: (options) => {
         const { xdm, data, clickedElement } = options;
 

diff --git a/test/functional/specs/Personalization/C17409728.js b/test/functional/specs/Personalization/C17409728.js
@@ -1,4 +1,3 @@
-/* eslint-disable no-underscore-dangle */
 /*
 Copyright 2023 Adobe. All rights reserved.
 This file is licensed to you under the Apache License, Version 2.0 (the "License");
@@ -419,6 +418,7 @@ test("Test C17409728: Includes rendered propositions as display notifications in
   );
   const hasPlatformDisplayNotifications = sendEventRequestBody.events.some(
     ({ xdm }) =>
+      // eslint-disable-next-line no-underscore-dangle
       xdm._experience?.decisioning?.propositionEventType?.display === 1,
   );
   await t

diff --git a/test/functional/specs/Personalization/C205528.js b/test/functional/specs/Personalization/C205528.js
@@ -47,7 +47,7 @@ test("Test C205528: A redirect offer should redirect the page to the URL in the
     await alloy.sendEvent({
       renderDecisions: true,
     });
-  } catch (e) {
+  } catch {
     // an exception will be thrown because a redirect will be executed within the Alloy Client Function
   } finally {
     await t.expect(redirectLogger.count(() => true)).eql(1);

diff --git a/test/integration/customBuildSize.js b/test/integration/customBuildSize.js
@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 /*
 Copyright 2024 Adobe. All rights reserved.
 This file is licensed to you under the Apache License, Version 2.0 (the "License");

diff --git a/test/unit/specs/components/ActivityCollector/attachClickActivityCollector.spec.js b/test/unit/specs/components/ActivityCollector/attachClickActivityCollector.spec.js
@@ -32,7 +32,7 @@ describe("ActivityCollector::attachClickActivityCollector", () => {
     lifecycle = {
       onClick: vi.fn().mockReturnValue(Promise.resolve()),
     };
-    // eslint-disable-next-line no-unused-vars
+
     vi.spyOn(document, "addEventListener").mockImplementation(
       (name, handler) => {
         clickHandler = handler;

diff --git a/test/unit/specs/core/network/requestMethods/injectSendBeaconRequest.spec.js b/test/unit/specs/core/network/requestMethods/injectSendBeaconRequest.spec.js
@@ -69,7 +69,7 @@ describe("injectSendBeaconRequest", () => {
         sendBeacon,
         sendFetchRequest,
       });
-      // eslint-disable-next-line consistent-return
+
       return sendBeaconRequest("https://example.com/endpoint", body).then(
         (result) => {
           expect(sendFetchRequest).not.toHaveBeenCalled();

diff --git a/test/unit/specs/utils/isInteger.spec.js b/test/unit/specs/utils/isInteger.spec.js
@@ -18,7 +18,6 @@ describe("isInteger", () => {
     [123, -123].forEach((value) => expect(isInteger(value)).toBe(true));
   });
 
-  // eslint-disable-next-line no-restricted-globals
   it("returns false if the value is not an integer", () => {
     [null, undefined, NaN, "abc", "123", 123.45, -123.45].forEach((value) =>
       expect(isInteger(value)).toBe(false),

diff --git a/test/unit/specs/utils/isNumber.spec.js b/test/unit/specs/utils/isNumber.spec.js
@@ -20,7 +20,6 @@ describe("isNumber", () => {
     );
   });
 
-  // eslint-disable-next-line no-restricted-globals
   it("returns false if the value is not a number", () => {
     [null, undefined, NaN, "abc", "123"].forEach((value) =>
       expect(isNumber(value)).toBe(false),

diff --git a/vitest.config.js b/vitest.config.js
@@ -8,7 +8,11 @@ export default defineProject({
     isolate: false,
     browser: {
       provider: "playwright",
-      name: "chromium",
+      instances: [
+        {
+          browser: "chromium",
+        },
+      ],
       enabled: true,
       headless: true,
     },
-Original file line number
+Diff line change
@@ Expand Up @@
                               ),
                             ),
                           );
-                        } catch (e) {
-                          // sss
+                        } catch {
+                          // Catch all errors.
                         }
                       }
                     }
@@ Expand Down @@