Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting action concurrency in manifest #176 #177

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

alexkli
Copy link
Contributor

@alexkli alexkli commented Jun 25, 2020

Description

Fixes #176

To discuss: the name choice of concurrency. The openwhisk manifest spec does not include it yet (note that concurrentActivations is a different limit). I simply used the same name as used in the OpenWhisk API & wsk.

How Has This Been Tested?

  • unit test
  • deployed example action in production with concurrency set in manifest.yml and tested that wsk action get <action> shows the concurrency limit

manifest.yml:

packages:
  __APP_PACKAGE__:
    license: Apache-2.0
    actions:
      worker:
        function: actions/worker/index.js
        web: 'yes'
        runtime: 'nodejs:10'
        limits:
          concurrency: 42
        annotations:
          require-adobe-auth: true

Result snippet of wsk action get $package-0.0.1/__secured_worker:

    "limits": {
        "timeout": 60000,
        "memory": 256,
        "logs": 10,
        "concurrency": 42
    },

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • Note: there is no section in the Firefly documentation for supported manifest files yet
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #177   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         2022      2024    +2     
  Branches       408       409    +1     
=========================================
+ Hits          2022      2024    +2     
Impacted Files Coverage Δ
src/runtime-helpers.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a0459...508023c. Read the comment docs.

@purplecabbage purplecabbage merged commit 580aa3d into adobe:master Jun 25, 2020
@alexkli alexkli deleted the action-concurrency branch June 25, 2020 23:29
purplecabbage pushed a commit to purplecabbage/aio-cli-plugin-runtime that referenced this pull request Jul 16, 2020
* Support setting action concurrency in manifest adobe#176
bhageena pushed a commit to bhageena/aio-cli-plugin-runtime that referenced this pull request Jul 21, 2021
* Support setting action concurrency in manifest adobe#176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support setting action concurrency in manifest
2 participants