Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use template module, expose add and delete command #113

Merged
merged 14 commits into from
Jan 8, 2020

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Dec 19, 2019

Description

This PR

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@moritzraho moritzraho changed the title Template modularization use template module, expose add and delete command Dec 19, 2019
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #113 into master will increase coverage by 2.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   89.07%   91.09%   +2.01%     
==========================================
  Files          11       15       +4     
  Lines         293      348      +55     
  Branches       39       36       -3     
==========================================
+ Hits          261      317      +56     
+ Misses         28       27       -1     
  Partials        4        4
Impacted Files Coverage Δ
src/commands/app/delete/web-assets.js 100% <100%> (ø)
src/commands/app/undeploy.js 100% <100%> (ø) ⬆️
src/commands/app/add/web-assets.js 100% <100%> (ø)
src/commands/app/deploy.js 92.59% <100%> (ø) ⬆️
src/commands/app/add/action.js 100% <100%> (ø)
src/commands/app/create.js 100% <100%> (ø) ⬆️
src/commands/app/delete/action.js 100% <100%> (ø)
src/commands/app/init.js 100% <100%> (+3.03%) ⬆️
src/commands/app/add/auth.js 100% <100%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb403e6...7f986a2. Read the comment docs.

@moritzraho moritzraho marked this pull request as ready for review December 19, 2019 18:35
@moritzraho
Copy link
Member Author

@purplecabbage this is ready to review! 🙂

@purplecabbage purplecabbage merged commit 264e2f7 into adobe:master Jan 8, 2020
@purplecabbage purplecabbage mentioned this pull request Jan 8, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants