Add Push to in-app unit tests #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymorale
commented
Feb 5, 2025
| @@ -90,4 +90,9 @@ dependencies { | |||
| exclude(group = "com.adobe.marketing.mobile", module = "core") | |||
| } | |||
| androidTestImplementation(project(":messagingtestutils")) | |||
| // specify byte buddy version to fix compatibility issue with jdk 21 | |||
There was a problem hiding this comment.
this resolves a byte buddy specific issue with jdk 21 which was blocking tests from running from within android studio.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-v3.3.0 #338 +/- ##
=============================================
Coverage ? 82.44%
Complexity ? 832
=============================================
Files ? 81
Lines ? 3873
Branches ? 593
=============================================
Hits ? 3193
Misses ? 489
Partials ? 191
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| "pushTracking.customAction", | ||
| messagingEvent.getEventData().get("eventType")); | ||
|
|
||
| Event pushToInappEvent = eventCaptor.getAllValues().get(0); |
There was a problem hiding this comment.
Should this even be dispatched if the updatePropositionsForSurfaces callback returns false?
| assertEquals(true, messagingEvent.getEventData().get("applicationOpened")); | ||
| assertEquals("mockXdmData", messagingEvent.getEventData().get("adobe_xdm")); | ||
| assertEquals( | ||
| "pushTracking.customAction", |
There was a problem hiding this comment.
nit: Can we also verify that adb_iam_id exists in the payload?
code/messaging/src/test/java/com/adobe/marketing/mobile/MessagingTests.java
Show resolved
Hide resolved
spoorthipujariadobe
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: