-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge to Staging for GA 4.0.0 release #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove session created event. Edge extension dispatches a session created event handle from the session start request response. The additional session created event dispatched from Edge Media is no longer needed. * Rename event source to 'createTracker'
Refactor MediaSession and RealTimeMediaSession to remove the sessionEndClosure. Instead, replace with better logging in RealTimeMediaSesssion when a session is aborted or ended and have MediaEventProcessor check for inactive sessions and remove in a bulk operation. This implementation creates parity with the Android implementation.
Remove trackerSessionId and dispatchQueue from MediaSession as they are not used. Remove trackerSessionId and trackerConfig from MediaEventProcessor.createSession() as they are not used.
Refactor MediaSession functions to remove session end closure
Use EventType and EventSource from Core development branch
* Convert create object public apis numeric values to int and corresponding test updates * Convert internal numeric values to int and test updates for the same * Update sample app with public API changes * Update documentation with the API updates * Convert all TS to TimeInterval * More updates based on reviews
…nds to align with the change of ts data type to TimeInterval (#23)
Change configuration key names to camelcase 'edgeMedia.'
Rename MediaPublicTracker to MediaTrackerEventGenerator
Add Media+LocationHint integration tests
Change config keys in docs to correct camelcase
#27) * Update ObjC class, enum names to avoid conflicts with AEPMedia classes * Update api-reference for objc name changes * Review fixes * Update based on reviews
…nsion version Bump to 4.0.0 (#31) * Updates for 4.0.0 release * Format fixes from SwiftLint * Fix warnings * Set deployment target to 13 for test apps * Add usage comment for check-version * Fix Package.swift format by removing extra whitespace * Set deployment version in test to 11 * Add execute permission to file. * Remove unused variable from test cases. * Use correct Core version in migration guide
* Update name to use 'Streaming Media' when formally referring to the extension * Use formal name 'Adobe Streaming Media for Edge Network' * Update extension name in podspec * Correct API name 'registerExtensions' * Update getting started configuration guide to point to Adobe Docs * Add README for Documentation folder * Update link references to Adobe Docs * Use direct links to experience league docs * Add section with programmatic configuration * Move dependencies to top of getting-started
addb
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
* Add before starting section to getting-started doc * Updates based on reviews * Updates based on reviews
addb
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First general availability release of the Adobe Streaming Media for Edge Network extension.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: