Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to Staging for GA 4.0.0 release #33

Merged
merged 21 commits into from
Jun 7, 2023
Merged

Merge to Staging for GA 4.0.0 release #33

merged 21 commits into from
Jun 7, 2023

Conversation

kevinlind
Copy link
Contributor

Description

First general availability release of the Adobe Streaming Media for Edge Network extension.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

kevinlind and others added 20 commits March 17, 2023 10:05
* Remove session created event.
Edge extension dispatches a session created event handle from the session start request response. The additional session created event dispatched from Edge Media is no longer needed.

* Rename event source to 'createTracker'
Refactor MediaSession and RealTimeMediaSession to remove the sessionEndClosure. Instead, replace with better logging in RealTimeMediaSesssion when a session is aborted or ended and have MediaEventProcessor check for inactive sessions and remove in a bulk operation. This implementation creates parity with the Android implementation.
Remove trackerSessionId and dispatchQueue from MediaSession as they are not used. Remove trackerSessionId and trackerConfig from MediaEventProcessor.createSession() as they are not used.
Refactor MediaSession functions to remove session end closure
Use EventType and EventSource from Core development branch
* Convert create object public apis numeric values to int and corresponding test updates

* Convert internal numeric values to int and test updates for the same

* Update sample app with public API changes

* Update documentation with the API updates

* Convert all TS to TimeInterval

* More updates based on reviews
…nds to align with the change of ts data type to TimeInterval (#23)
Change configuration key names to camelcase 'edgeMedia.'
Rename MediaPublicTracker to MediaTrackerEventGenerator
Add Media+LocationHint integration tests
Change config keys in docs to correct camelcase
#27)

* Update ObjC class, enum names to avoid conflicts with AEPMedia classes

* Update api-reference for objc name changes

* Review fixes

* Update based on reviews
…nsion version Bump to 4.0.0 (#31)

* Updates for 4.0.0 release

* Format fixes from SwiftLint

* Fix warnings

* Set deployment target to 13 for test apps

* Add usage comment for check-version

* Fix Package.swift format by removing extra whitespace

* Set deployment version in test to 11

* Add execute permission to file.

* Remove unused variable from test cases.

* Use correct Core version in migration guide
* Update name to use 'Streaming Media' when formally referring to the extension

* Use formal name 'Adobe Streaming Media for Edge Network'

* Update extension name in podspec

* Correct API name 'registerExtensions'

* Update getting started configuration guide to point to Adobe Docs

* Add README for Documentation folder

* Update link references to Adobe Docs

* Use direct links to experience league docs

* Add section with programmatic configuration

* Move dependencies to top of getting-started
@kevinlind kevinlind requested a review from addb June 6, 2023 23:44
Copy link
Contributor

@addb addb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

* Add before starting section to getting-started doc

* Updates based on reviews

* Updates based on reviews
@emdobrin emdobrin merged commit 066c207 into staging Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants