Add Kotlin sample for API reference #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdobrin
reviewed
Jan 31, 2023
Documentation/api-reference.md
Outdated
Comment on lines
601
to
605
| val id = item.getId() | ||
|
|
||
| val state = item.getAuthenticatedState() | ||
|
|
||
| val primary = item.isPrimary() |
There was a problem hiding this comment.
we can use property access syntax for these getters
val id = item.id
val state = item.authenticatedState
val primary = item.isPrimary
emdobrin
reviewed
Jan 31, 2023
|
|
||
| ##### Syntax | ||
| ```kotlin | ||
| fun removeIdentity(item: IdentityItem, namespace: String) |
There was a problem hiding this comment.
some of these params are optional without these changes #97
Codecov Report
@@ Coverage Diff @@
## dev-v2.0.0 #95 +/- ##
===========================================
Coverage 93.36% 93.36%
===========================================
Files 12 12
Lines 678 678
Branches 103 103
===========================================
Hits 633 633
Misses 16 16
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. |
kevinlind
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: