Update dependencies to core extensions #94
Conversation
Codecov Report
@@ Coverage Diff @@
## dev-v2.0.0 #94 +/- ##
===========================================
Coverage 93.36% 93.36%
===========================================
Files 12 12
Lines 678 678
Branches 103 103
===========================================
Hits 633 633
Misses 16 16
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. |
code/app/build.gradle
Outdated
| transitive = false | ||
| } | ||
| implementation "com.adobe.marketing.mobile:core:${rootProject.mavenCoreVersion}" | ||
| implementation 'com.adobe.marketing.mobile:identity:2.0.0' |
There was a problem hiding this comment.
nit: mavenDirectIdentityVersion=2.0.0
implementation 'com.adobe.marketing.mobile:identity:${rootProject. mavenDirectIdentityVersion}'
There was a problem hiding this comment.
gradle.properties holds prod dependencies to declare min compatible version for current release. For tests/test app we often update to latest version available for quick tests, so I would prefer not lock that in a variable. what do you think?
There was a problem hiding this comment.
That makes sense. I wanted to see if we would like to test the app and integration tests with the same version. Should we fix to full specific version for tests instead of dynamic one?
There was a problem hiding this comment.
updated all test app dependencies to 2.+ so they work with the snapshot and we don't need to update later for 2.0
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: