Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev v2.0.0 -> Staging for second snapshot #92

Merged
merged 18 commits into from
Jan 30, 2023
Merged

Dev v2.0.0 -> Staging for second snapshot #92

merged 18 commits into from
Jan 30, 2023

Conversation

cacheung
Copy link
Contributor

Dev v2.0.0 -> Staging for second snapshot with doc and using Core MapUtils changes

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

timkimadobe and others added 18 commits January 19, 2023 12:12
* Update functional test helper to use named collections instead of android shared preferences directly

* Update docs to NamedCollection
Update implementation from 2+ to 2.0.0
Update sample code in doc.
Update Readme
Use Core MapUtils for isNullOrEmpty
Updatet documentation, make toc for Readme.md. Move advertising-identifier content to its own file.
Update getting-started.md
Remove setLogLevel in the sample code
Update Documentation
Fix typo in a link
Update descriptions for related projects
Incorporated the review comment part 1
Update getting-started page format.
More update for the documentation
Update doc for the review comment
 The sample failing for adding this, will look at this later. Remove scheme change in AndroidManifest.
Update core github api links
Add deeplink to the test app and update get started doc
Update doc for v.2.0.0 and use Core MapUtils
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #92 (5be6af6) into staging (e12492d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           staging      #92      +/-   ##
===========================================
- Coverage    93.37%   93.36%   -0.01%     
===========================================
  Files           12       12              
  Lines          679      678       -1     
  Branches       103      103              
===========================================
- Hits           634      633       -1     
  Misses          16       16              
  Partials        29       29              
Flag Coverage Δ
functional-tests 67.55% <50.00%> (-0.93%) ⬇️
unit-tests 93.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...om/adobe/marketing/mobile/edge/identity/Utils.java 100.00% <ø> (ø)
...be/marketing/mobile/edge/identity/IdentityMap.java 97.54% <100.00%> (ø)
.../marketing/mobile/edge/identity/IdentityState.java 95.83% <100.00%> (ø)

@emdobrin emdobrin merged commit 2ae290d into staging Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants