Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update failing tests #34

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Update failing tests #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e33836
Wait for test threads to finsh to allow direct Identity extension to …
kevinlind Mar 31, 2021
2fa996f
In ECID handling tests, register both extensions after directly setti…
kevinlind Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions ...c/androidTest/java/com/adobe/marketing/mobile/edge/identity/IdentityECIDHandlingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,16 +116,14 @@ public void testECID_onResetClearsOldECID() throws Exception {
@Test
public void testECID_AreDifferentAfterPrivacyChange() throws Exception {
/// Test Edge Identity and IdentityDirect have same ECID on bootup, and after privacy change ECIDs are different
registerIdentityDirectExtension();

// register EdgeIdentity extension
Identity.registerExtension();
setIdentityDirectPersistedECID("legacyECID");
registerBothIdentityExtensions();
TestHelper.waitForThreads(2000);

// verify ECID for both extensions are same
String directECID = getIdentityDirectECIDSync();
String edgeECID = getExperienceCloudIdSync();
assertNotNull(edgeECID);
assertEquals("legacyECID", edgeECID);
assertEquals(directECID, edgeECID);

// Toggle privacy
Expand All @@ -142,16 +140,14 @@ public void testECID_AreDifferentAfterResetIdentitiesAndPrivacyChange() throws E
/// Test Edge Identity and IdentityDirect have same ECID on bootup, and after resetIdentities and privacy change ECIDs are different

// 1) Register Identity then Edge Identity and verify both have same ECID
registerIdentityDirectExtension();

// register EdgeIdentity extension
Identity.registerExtension();
setIdentityDirectPersistedECID("legacyECID");
registerBothIdentityExtensions();
TestHelper.waitForThreads(2000);

// verify ECID for both extensions are same
String directECID = getIdentityDirectECIDSync();
String edgeECID = getExperienceCloudIdSync();
assertNotNull(edgeECID);
assertEquals("legacyECID", edgeECID);
assertEquals(directECID, edgeECID);

// 2) Reset identities and toggle privacy and verify legacy ECID added to IdentityMap
Expand Down