Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Core dependency to 3.0.0 (non snapshot) version #126

Merged

Conversation

kevinlind
Copy link
Collaborator

@kevinlind kevinlind commented Apr 1, 2024

Description

Updating dependencies to non-snapshot versions of 3.0.0.

  • Sets Core and Identity dependencies in edgeidentity module to non-snapshot versions
  • Updates app module to use non-snapshot version of Core. However, as Edge Identity is released before Edge and Consent, the test app must still reference the 3.0.0-SNAPSHOT releases of these extensions.

Note, as Core 3.0.0 is not yet released, the CI build will fail.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kevinlind kevinlind requested review from cacheung and emdobrin April 1, 2024 20:40
implementation("com.adobe.marketing.mobile:edgeconsent:3.0.0-SNAPSHOT") {
exclude(group = "com.adobe.marketing.mobile", module = "edge")
exclude(group = "com.adobe.marketing.mobile", module = "core")

}
implementation("com.adobe.marketing.mobile:assurance:2.+")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assurance should use 3.0.0-SNAPSHOT

Copy link
Contributor

@cacheung cacheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also include the readme change in this PR?
https://github.com/kevinlind/aepsdk-edgeidentity-android/tree/staging-v3-dep-updates

To open and run the project, open the code/settings.gradle.kt file in Android Studio.

@emdobrin
Copy link
Contributor

emdobrin commented Apr 1, 2024

could we also include the readme/documentation getting started with the app doc changes with this pr?

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

❗ No coverage uploaded for pull request base (staging-v3-dep-updates@16348b2). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             staging-v3-dep-updates     #126   +/-   ##
=========================================================
  Coverage                          ?   93.40%           
  Complexity                        ?      224           
=========================================================
  Files                             ?       12           
  Lines                             ?      682           
  Branches                          ?      104           
=========================================================
  Hits                              ?      637           
  Misses                            ?       17           
  Partials                          ?       28           
Flag Coverage Δ
-tests 93.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

}
implementation("com.adobe.marketing.mobile:assurance:2.+")
implementation("com.adobe.marketing.mobile:assurance:3.0.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we change this to 3.0.0-SNAPSHOT we can merge into staging directly, just saying 👯

@kevinlind kevinlind merged commit da9daa8 into adobe:staging-v3-dep-updates Apr 2, 2024
7 checks passed
@kevinlind kevinlind deleted the staging-v3-dep-updates branch April 2, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants