-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Core dependency to 3.0.0 (non snapshot) version #126
Update Core dependency to 3.0.0 (non snapshot) version #126
Conversation
code/app/build.gradle.kts
Outdated
implementation("com.adobe.marketing.mobile:edgeconsent:3.0.0-SNAPSHOT") { | ||
exclude(group = "com.adobe.marketing.mobile", module = "edge") | ||
exclude(group = "com.adobe.marketing.mobile", module = "core") | ||
|
||
} | ||
implementation("com.adobe.marketing.mobile:assurance:2.+") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assurance should use 3.0.0-SNAPSHOT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also include the readme change in this PR?
https://github.com/kevinlind/aepsdk-edgeidentity-android/tree/staging-v3-dep-updates
To open and run the project, open the code/settings.gradle.kt file in Android Studio.
could we also include the readme/documentation getting started with the app doc changes with this pr? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## staging-v3-dep-updates #126 +/- ##
=========================================================
Coverage ? 93.40%
Complexity ? 224
=========================================================
Files ? 12
Lines ? 682
Branches ? 104
=========================================================
Hits ? 637
Misses ? 17
Partials ? 28
Flags with carried forward coverage won't be shown. Click here to find out more. |
} | ||
implementation("com.adobe.marketing.mobile:assurance:2.+") | ||
implementation("com.adobe.marketing.mobile:assurance:3.0.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we change this to 3.0.0-SNAPSHOT we can merge into staging directly, just saying 👯
Description
Updating dependencies to non-snapshot versions of 3.0.0.
Note, as Core 3.0.0 is not yet released, the CI build will fail.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: