Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spotless and format licenses #117

Merged
merged 12 commits into from
Feb 22, 2024

Conversation

cacheung
Copy link
Contributor

Run spotlessCheck and spotlessApply to fix format for the files.
Run format-license to add license to all the files.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Android 3.0.0 migration update
disable assemble-app
disable assemble-phone
remove Assemble App
Exclude duplicated edgeidentity and core module in App gradle
Update Spotless and License for all the files
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Merging #117 (4bf8f5c) into dev-v3.0.0 (11b4b15) will decrease coverage by 0.04%.
Report is 1 commits behind head on dev-v3.0.0.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             dev-v3.0.0     #117      +/-   ##
================================================
- Coverage         93.44%   93.40%   -0.04%     
- Complexity            0      224     +224     
================================================
  Files                12       12              
  Lines               686      682       -4     
  Branches            104      104              
================================================
- Hits                641      637       -4     
  Misses               17       17              
  Partials             28       28              
Flag Coverage Δ
-tests 93.40% <ø> (?)
functional-tests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...adobe/marketing/mobile/edge/identity/Identity.java 91.59% <ø> (-0.30%) ⬇️
...keting/mobile/edge/identity/IdentityExtension.java 99.19% <ø> (ø)
...e/marketing/mobile/edge/identity/IdentityItem.java 70.21% <ø> (ø)
...be/marketing/mobile/edge/identity/IdentityMap.java 98.40% <ø> (ø)
.../marketing/mobile/edge/identity/IdentityState.java 95.83% <ø> (ø)

update github yml file
enable checkformat and lint
SpotlessApply
Remove extra variables
@@ -27,8 +27,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed main

@@ -11,15 +11,15 @@ format:
(./code/gradlew -p code/$(EXTENSION-LIBRARY-FOLDER-NAME) spotlessApply)
(./code/gradlew -p code/$(TEST-APP-FOLDER-NAME) spotlessApply)

# format-license:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled licencse, spotless and lint

@cacheung cacheung marked this pull request as ready for review February 22, 2024 00:17
Update License header to its original creation date
@kevinlind kevinlind merged commit 3839f3d into adobe:dev-v3.0.0 Feb 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants