Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLATIR-45069: Add theme overrides for AEP Presentables #731

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

prudrabhat
Copy link
Contributor

@prudrabhat prudrabhat commented Jan 21, 2025

Description

Currently UIService components are built to inherit the current activity's theme to maintain the app's styling. While this works for most cases, background is one the items where inheriting the parent theme as is does not work well, as this property applies to the view background for all views within an activity - covering the draggable floating button area, covering the in-app message background window etc.

This PR attempts to solve the problem by creating a copy of the current app theme and overriding specific attributes with values that are needed.

Related Issue

PLATIR-45069

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 68.97%. Comparing base (66316d1) to head (8f0b5c6).

Files with missing lines Patch % Lines
...keting/mobile/services/ui/common/AEPPresentable.kt 0.00% 15 Missing ⚠️
...eting/mobile/services/ui/alert/AlertPresentable.kt 0.00% 1 Missing ⚠️
...ces/ui/floatingbutton/FloatingButtonPresentable.kt 0.00% 1 Missing ⚠️
...services/ui/floatingbutton/views/FloatingButton.kt 0.00% 1 Missing ⚠️
...ile/services/ui/message/InAppMessagePresentable.kt 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (66316d1) and HEAD (8f0b5c6). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (66316d1) HEAD (8f0b5c6)
functional-tests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #731       +/-   ##
=============================================
- Coverage     81.59%   68.97%   -12.62%     
+ Complexity     2141     1938      -203     
=============================================
  Files           194      194               
  Lines          8937     8953       +16     
  Branches       1121     1121               
=============================================
- Hits           7292     6175     -1117     
- Misses         1091     2313     +1222     
+ Partials        554      465       -89     
Flag Coverage Δ
functional-tests ?
unit-tests 68.97% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...eting/mobile/services/ui/alert/AlertPresentable.kt 40.74% <0.00%> (ø)
...ces/ui/floatingbutton/FloatingButtonPresentable.kt 59.38% <0.00%> (ø)
...services/ui/floatingbutton/views/FloatingButton.kt 0.00% <0.00%> (-75.81%) ⬇️
...ile/services/ui/message/InAppMessagePresentable.kt 32.47% <0.00%> (ø)
...keting/mobile/services/ui/common/AEPPresentable.kt 87.10% <0.00%> (-7.64%) ⬇️

... and 38 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant