Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLATIR-34650] Fix IAM bug causing webview creation failure from blocking ui #593

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

sbenedicadb
Copy link
Member

Description

Also fixed the test app to actually display a dismissible message.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #593 (e0dedde) into dev-v2.6.1-core (5f6f0c0) will decrease coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             dev-v2.6.1-core     #593      +/-   ##
=====================================================
- Coverage              86.80%   86.68%   -0.12%     
+ Complexity              1519     1518       -1     
=====================================================
  Files                    127      127              
  Lines                   5675     5675              
  Branches                 782      782              
=====================================================
- Hits                    4926     4919       -7     
- Misses                   421      425       +4     
- Partials                 328      331       +3     
Flag Coverage Δ
functional-tests 23.98% <ø> (ø)
unit-tests 79.31% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@sbenedicadb sbenedicadb merged commit d2deef2 into adobe:dev-v2.6.1-core Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants