Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample setup for the wcm.io caconfig editor #1410

Merged
merged 4 commits into from
Feb 25, 2021

Conversation

vladbailescu
Copy link
Member

@vladbailescu vladbailescu commented Feb 23, 2021

image
image

* Since #1234 is updating HtmlPageItemsConfig to be editable by wcm.io Context-Aware Configuration Editor, here's a sample setup.
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1410 (2d3a822) into development (786d85d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1410   +/-   ##
==============================================
  Coverage          86.08%   86.08%           
  Complexity          1939     1939           
==============================================
  Files                181      181           
  Lines               5355     5355           
  Branches             814      811    -3     
==============================================
  Hits                4610     4610           
  Misses               299      299           
  Partials             446      446           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786d85d...1c7ef06. Read the comment docs.

@jckautzmann
Copy link
Contributor

Please add some docs (e.g. in the README) how to use this caconfig editor.

Copy link
Contributor

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume you also need a OSGi configuration to enable https://wcm.io/caconfig/extensions/persistence-strategies.html to make sure the complex config structres of HtmlPageItemsConfig is persisted and read correctly?
see https://wcm.io/caconfig/extensions/persistence-strategies.html

@@ -57,7 +57,18 @@
<artifactId>filevault-package-maven-plugin</artifactId>
<extensions>true</extensions>
<configuration>
<packageType>application</packageType>
<packageType>mixed</packageType>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably "container" is a better option than "mixed" which is discouraged?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

container does not allow content. We would need to create a container just for the bundles, which is not that helpful.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vladbailescu
Copy link
Member Author

vladbailescu commented Feb 24, 2021

@jckautzmann :

Please add some docs (e.g. in the README) how to use this caconfig editor.

I added a file describing our configurations in b79b415
Also added screenshots with the editor to this PR as it's referenced in the https://github.com/adobe/aem-core-wcm-components/blob/master/CONFIGS.md file

@vladbailescu
Copy link
Member Author

@stefanseifert :

i assume you also need a OSGi configuration to enable https://wcm.io/caconfig/extensions/persistence-strategies.html to make sure the complex config structres of HtmlPageItemsConfig is persisted and read correctly?
see https://wcm.io/caconfig/extensions/persistence-strategies.html

I added page persistence strategy configuration in 1c7ef06

@jckautzmann
Copy link
Contributor

It would be nice to link the CONFIGS from the main README.

@stefanseifert
Copy link
Contributor

stefanseifert commented Feb 24, 2021

@vladbailescu

I added page persistence strategy configuration in 1c7ef06

ok - please note that io.wcm.caconfig.extensions.persistence.impl.PagePersistenceStrategy is not a factory but a singleton configuration - so probably the suffix -components-library should removed.

@vladbailescu vladbailescu merged commit 939e191 into development Feb 25, 2021
@vladbailescu vladbailescu deleted the issue/1234-examples branch February 25, 2021 07:13
vladbailescu added a commit that referenced this pull request Feb 25, 2021
* Since #1234 is updating HtmlPageItemsConfig to be editable by wcm.io Context-Aware Configuration Editor, here's a sample setup.
* Added configuration for PagePersistenceStrategy
vladbailescu added a commit that referenced this pull request Mar 3, 2021
 * Restructured wcm.io ca-config editor embeds to a ui.config package
 * Added aggregator module for examples
vladbailescu added a commit that referenced this pull request Mar 5, 2021
 * Restructured wcm.io ca-config editor embeds to a ui.config package
 * Added aggregator module for examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants