-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample setup for the wcm.io caconfig editor #1410
Conversation
vladbailescu
commented
Feb 23, 2021
•
edited
Loading
edited
- Since [Page] Html Page Items context-aware configuration not editable #1234 is updating HtmlPageItemsConfig to be editable by wcm.io Context-Aware Configuration Editor, here's a sample setup.
* Since #1234 is updating HtmlPageItemsConfig to be editable by wcm.io Context-Aware Configuration Editor, here's a sample setup.
Codecov Report
@@ Coverage Diff @@
## development #1410 +/- ##
==============================================
Coverage 86.08% 86.08%
Complexity 1939 1939
==============================================
Files 181 181
Lines 5355 5355
Branches 814 811 -3
==============================================
Hits 4610 4610
Misses 299 299
Partials 446 446 Continue to review full report at Codecov.
|
Please add some docs (e.g. in the README) how to use this caconfig editor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i assume you also need a OSGi configuration to enable https://wcm.io/caconfig/extensions/persistence-strategies.html
to make sure the complex config structres of HtmlPageItemsConfig is persisted and read correctly?
see https://wcm.io/caconfig/extensions/persistence-strategies.html
@@ -57,7 +57,18 @@ | |||
<artifactId>filevault-package-maven-plugin</artifactId> | |||
<extensions>true</extensions> | |||
<configuration> | |||
<packageType>application</packageType> | |||
<packageType>mixed</packageType> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably "container" is a better option than "mixed" which is discouraged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
container
does not allow content. We would need to create a container
just for the bundles, which is not that helpful.
* Added configuration for PagePersistenceStrategy
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I added a file describing our configurations in b79b415 |
I added page persistence strategy configuration in 1c7ef06 |
It would be nice to link the CONFIGS from the main README. |
ok - please note that |
* Since #1234 is updating HtmlPageItemsConfig to be editable by wcm.io Context-Aware Configuration Editor, here's a sample setup. * Added configuration for PagePersistenceStrategy
* Restructured wcm.io ca-config editor embeds to a ui.config package * Added aggregator module for examples
* Restructured wcm.io ca-config editor embeds to a ui.config package * Added aggregator module for examples