Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(component-directive): make the component directive extensible #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

niekraaijmakers
Copy link
Contributor

Description

Adding some hooks that can be used to extend the component directive class.
This will enable the content fragment component to reuse this logic instead of duplicating it.

Pending PR : #46

Related Issue

#43

How Has This Been Tested?

Unit tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Niek Raaijmakers added 2 commits June 15, 2021 14:21
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #48 (dddf57a) into master (0b61f1d) will not change coverage.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files          10       10           
  Lines         171      171           
  Branches       29       29           
=======================================
  Hits          150      150           
  Misses         14       14           
  Partials        7        7           
Impacted Files Coverage Δ
src/lib/layout/aem-component.directive.ts 82.85% <69.23%> (ø)
src/lib/layout/component-mapping.ts 88.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b61f1d...dddf57a. Read the comment docs.

@habansal habansal requested a review from CezCz July 27, 2021 21:21
@fdambrosio
Copy link

hi, there's news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants