Allow any language with DFLT script #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsousa
previously approved these changes
Jul 20, 2018
|
very nice @readroberts |
anthrotype
reviewed
Jul 20, 2018
| @@ -202,6 +202,7 @@ struct featCtx_ { | |||
| #define GF_SEEN_GDEF_GLYPHCLASS (1 << 2) /* An explicit GDEF glyph class has been seen. */ | |||
| #define GF_SEEN_IGNORE_CLASS_FLAG (1 << 3) /* any lookup flag has been seen for ignoring any GDEF class. */ | |||
| #define GF_SEEN_MARK_CLASS_FLAG (1 << 4) /* any lookup flag has been seen for ignoring any GDEF class. */ | |||
| #define GF_SEEN_NON_DFLT_SCRIPT_FLAG (1 << 5) /* any lookup flag has been seen for ignoring any GDEF class. */ | |||
There was a problem hiding this comment.
the comment text doesn't match the macro name
There was a problem hiding this comment.
@miguelsousa @cjchapman I see I did indeed miss updating the comment - all done now.
cjchapman
suggested changes
Jul 20, 2018
|
@readroberts I'll take care of the merge conflict in |
cjchapman
previously approved these changes
Jul 20, 2018
miguelsousa
force-pushed
the
fix-issue438
branch
from
bbf5d95 to
4c65a12
Compare
miguelsousa
approved these changes
Jul 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438