Fix inconsistency of use of regionCount variable in tx.varread.varread.c #272
Assignees
Comments
readroberts
added a commit
that referenced
this issue
May 24, 2018
… variable in tx.varread.varread.c This update makes no change in function: it simply renames variables and fields to avoid confusion by developers.
Merged
cjchapman
pushed a commit
that referenced
this issue
May 30, 2018
* [tx][varread] Fix issue #272: Fix inconsistency of use of regionCount variable in tx.varread.varread.c This update makes no change in function: it simply renames variables and fields to avoid confusion by developers. * [tx][tx_test.py] Add test for reading and snapshotting simple CFF2 VF font to test fix for issue #272
|
Fixed via #397 |
schriftgestalt
pushed a commit
to schriftgestalt/afdko
that referenced
this issue
May 18, 2019
* [tx][varread] Fix issue adobe-type-tools#272: Fix inconsistency of use of regionCount variable in tx.varread.varread.c This update makes no change in function: it simply renames variables and fields to avoid confusion by developers. * [tx][tx_test.py] Add test for reading and snapshotting simple CFF2 VF font to test fix for issue adobe-type-tools#272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The function tx.varread.varread.c:var_getIVSRegionIndices() takes a variable named regionCount. In some call chains, this is set to the itemVariationDataSubtable region index count, and in others it is set to the RegionList index count. In all cases, it should be set to the RegionList index count, and the variables in this file which are named 'regionCount' should be renamed to reflect whether they contain the RegionList index count, or the data subtable region index count. See:
https://github.com/adobe-type-tools/afdko/blob/master/afdko/Tools/Programs/public/lib/source/varread/varread.c#L949
The text was updated successfully, but these errors were encountered: