-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logging to reflect accurate user key #363
Comments
@shasibhusanJena FYI - the links here and in the linked issue that point to specific lines in the source code are out of date. |
oh ok. help me how can I produce same bug while running on my local if below changes I do have to enable to see this error on my local |
I feel this is what we are trying to find out why this key getting 'none' ex: 2019-02-11 21:19:04 17504 DEBUG processor - Source attrs, before: {'email': '[email protected]', 'identity_type': None, 'username': None, 'domain': None, 'givenName': 'deepak', 'sn': 'kumar', 'c': None, 'bc': None, 'subco': None} Need to check why identity_type and domain name setting to "None" instead of printing correct value |
The user key used in certain log entries reflects the directory user record. Elements of the key - username, domain, email - can be updated by the after_mapping_hook. When any key element is updated, the key used in log messages is not updated. This can cause confusion - see #362.
Before writing the key to the logger, we should update it to reflect the umapi record. We don't necessarily need to update the key itself, which is used in internal data structures. At the very least, we should modify its representation when adding it to logs (perhaps with a new lookup table).
The text was updated successfully, but these errors were encountered: