Document pattern deviation from specification #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We document in the JSON and RDF schema `README` files, that we deviate from the pattern in the specification of AASd-130, due to the fact that most schema engines test UTF-16, instead of the used UTF-32. For the full discussion, refer to #362
BirgitBoss
approved these changes
May 31, 2024
mristin
approved these changes
May 31, 2024
Comment on lines
+78
to
+80
| Since most RDFS engines we tested operated on UTF-16 and could not handle UTF-32, we transpiled the pattern from AASd-130, which uses UTF-32 in the specification, into UTF-16. | ||
| This is a trade-off between correctness and practicality. | ||
| See [#362](https://github.com/admin-shell-io/aas-specs/issues/362) for the details. |
There was a problem hiding this comment.
I don't think that RDFS engines allow for arbitrary test to be encoded. Actually, I imagine that XML strings are used to encode text by default, so AASd-130 is meaningless (all text must conform to XML text to be ingested in RDF in the first place).
@sebbader-sap can you please have a look at this point?
Co-authored-by: Marko Ristin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We document in the JSON and RDF schema
READMEfiles, that we deviate from the pattern in the
specification of AASd-130, due to the fact that
most schema engines test UTF-16, instead
of the used UTF-32.
For the full discussion, refer to #362