Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle valueId and isCaseOf like semanticId #396

Closed
BirgitBoss opened this issue Apr 10, 2024 · 3 comments
Closed

Handle valueId and isCaseOf like semanticId #396

BirgitBoss opened this issue Apr 10, 2024 · 3 comments
Labels
accepted accepted in principle to be fixed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Milestone
V3.1

Comments

@BirgitBoss
Copy link
Collaborator

BirgitBoss commented Apr 10, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
In #376 it was decided that all semanticIds should be external references.

valueId as defined for Property and MultiLanguageProperty are also referencing a concept definition. This is why also here text should be added that they are handled like semanticIds with the same constraints and recommendations etc.

isCaseOf is also a reference to a concept definition and therefore should also be handled like semanticId
@BirgitBoss BirgitBoss added this to the V3.1 milestone Apr 10, 2024
@BirgitBoss BirgitBoss added specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally requires workstream approval strategic decision proposal needs to be prepared in TF spec team labels Apr 12, 2024
@BirgitBoss BirgitBoss mentioned this issue Apr 20, 2024
Closed
@BirgitBoss BirgitBoss changed the title Handle valueId like semanticId Handle valueId and isCaseOf like semanticId Apr 22, 2024
BirgitBoss added a commit that referenced this issue Apr 22, 2024
@BirgitBoss
Update chapter OPC UA #373
78a6427 
valueid and isCaseOf: like semanticId  #396
update bibliography
update changeLog
@BirgitBoss BirgitBoss mentioned this issue Apr 22, 2024
Merged
BirgitBoss added a commit that referenced this issue Apr 30, 2024
@BirgitBoss @zrgt
Update OPC UA, Bibliography & isCaseOf/valueId (#419)
7ec58b2 
* Update chapter OPC UA #373
valueId and isCaseOf: like semanticId  #396
update bibliography
update changeLog

* fix []

Co-authored-by: Igor Garmaev <[email protected]>
@BirgitBoss
Copy link
Collaborator Author

TF 2024-06-12 Decision Proposal
Handle valueId (with CD for values of enumerations) and isCaseOf of ConceptDescriptions like all other references to semantic definitions

@BirgitBoss BirgitBoss added ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream and removed requires workstream approval strategic decision proposal needs to be prepared in TF spec team labels Jun 12, 2024
@BirgitBoss
Copy link
Collaborator Author

Workstream AAS Spec 2024-06-13
accepted, handling the same as for semanticId

@BirgitBoss BirgitBoss added accepted accepted in principle to be fixed and removed ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream labels Jun 13, 2024
@BirgitBoss
Copy link
Collaborator Author

see decision in #376 (comment)

BirgitBoss added a commit that referenced this issue Nov 19, 2024
@BirgitBoss
closes #376
c4c473d 
closes #396
semantic identifier for semanticId, valueId, isCaseOf
no recommendation any longer to use external references
@BirgitBoss BirgitBoss mentioned this issue Nov 19, 2024
Merged
BirgitBoss added a commit that referenced this issue Dec 13, 2024
@BirgitBoss
closes #376 (#486)
a6eee9a 
closes #396
semantic identifier for semanticId, valueId, isCaseOf
no recommendation any longer to use external references
@BirgitBoss BirgitBoss reopened this Dec 15, 2024
BirgitBoss added a commit that referenced this issue Dec 15, 2024
@BirgitBoss
fix #396 continued
5c6ff4b
BirgitBoss added a commit that referenced this issue Dec 15, 2024
@BirgitBoss
Continue working on issues (#508)
2dfc645 
* remove zip file, was not added on purpose

* fix #333 recursion depth max 32

* fix #333 recursion depth continues
fix #388 UML Cardinality

* fix #396 continued

* matching strategy references

* fix figure ContainerElement in SubmodelElement Overview

* check to mention all issues closed in v3.1
BirgitBoss added a commit that referenced this issue Dec 15, 2024
@BirgitBoss
Annex Overview Constraints and final editorial fixes (#510)
0d19c9b 
* remove zip file, was not added on purpose

* fix #333 recursion depth max 32

* fix #333 recursion depth continues
fix #388 UML Cardinality

* fix #396 continued

* matching strategy references

* fix figure ContainerElement in SubmodelElement Overview

* check to mention all issues closed in v3.1

* minor editorial changes
fix chapter structure in mapping

* fix #509 Annex Overview Constraints
@seicke seicke mentioned this issue Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted accepted in principle to be fixed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Projects
None yet
Milestone
V3.1
Development

No branches or pull requests
1 participant
@BirgitBoss