Skip to content

Commit

Permalink
engine: Add ExportToSst method with all logic moved to C++
Browse files Browse the repository at this point in the history
Export was previously executed using an MVCCIncrementalIterator
where the logic handling iteration over the diff of the key
range [startKey, endKey) and time range (startTime, endTime]
was written in Go. This iteration involved making a cgo call
to find every key, along with another cgo call for writing
each key to the sstable.
This migration resolves the aforementioned performance
bottleneck (cockroachdb#18884), by pushing all the required logic to C++
and exposing a single export method.

Release note: Performance improvement to the BACKUP process.
  • Loading branch information
adityamaru27 committed May 22, 2019
1 parent db54658 commit 825d630
Show file tree
Hide file tree
Showing 4 changed files with 99 additions and 1,037 deletions.
283 changes: 0 additions & 283 deletions pkg/ccl/storageccl/engineccl/mvcc.go

This file was deleted.

Loading

0 comments on commit 825d630

Please sign in to comment.