Skip to content

Commit

Permalink
xds-failover: disabling flaky and potential flaky tests
Browse files Browse the repository at this point in the history
Signed-off-by: Adi Suissa-Peleg <[email protected]>
  • Loading branch information
adisuissa committed Jul 3, 2024
1 parent 9013566 commit ae84112
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ TEST_P(XdsFailoverAdsIntegrationTest, FailoverNotAttemptedWhenPrimaryAvailable)

// Validates that when there's a failover defined, and the primary isn't responding,
// then Envoy will use the failover, and will receive a valid config.
TEST_P(XdsFailoverAdsIntegrationTest, StartupPrimaryNotResponding) {
TEST_P(XdsFailoverAdsIntegrationTest, DISABLED_StartupPrimaryNotResponding) {
initialize();

// Expect a connection to the primary. Reject the connection immediately.
Expand All @@ -320,7 +320,7 @@ TEST_P(XdsFailoverAdsIntegrationTest, StartupPrimaryNotResponding) {

// Validates that when there's a failover defined, and the primary returns a
// gRPC failure, then Envoy will use the failover, and will receive a valid config.
TEST_P(XdsFailoverAdsIntegrationTest, StartupPrimaryGrpcFailure) {
TEST_P(XdsFailoverAdsIntegrationTest, DISABLED_StartupPrimaryGrpcFailure) {
#ifdef ENVOY_ENABLE_UHV
// With UHV the finishGrpcStream() isn't detected as invalid frame because of
// no ":status" header, unless "envoy.reloadable_features.enable_universal_header_validator"
Expand Down Expand Up @@ -363,7 +363,7 @@ TEST_P(XdsFailoverAdsIntegrationTest, StartupPrimaryGrpcFailure) {
// Validates that when there's a failover defined, and the primary returns a
// gRPC failure after sending headers, then Envoy will use the failover, and will receive a valid
// config.
TEST_P(XdsFailoverAdsIntegrationTest, StartupPrimaryGrpcFailureAfterHeaders) {
TEST_P(XdsFailoverAdsIntegrationTest, DISABLED_StartupPrimaryGrpcFailureAfterHeaders) {
#ifdef ENVOY_ENABLE_UHV
// With UHV the finishGrpcStream() isn't detected as invalid frame because of
// no ":status" header, unless "envoy.reloadable_features.enable_universal_header_validator"
Expand Down Expand Up @@ -401,7 +401,7 @@ TEST_P(XdsFailoverAdsIntegrationTest, StartupPrimaryGrpcFailureAfterHeaders) {
}

// Validate that once primary answers, failover will not be used, even after disconnecting.
TEST_P(XdsFailoverAdsIntegrationTest, NoFailoverUseAfterPrimaryResponse) {
TEST_P(XdsFailoverAdsIntegrationTest, DISABLED_NoFailoverUseAfterPrimaryResponse) {
#ifdef ENVOY_ENABLE_UHV
// With UHV the finishGrpcStream() isn't detected as invalid frame because of
// no ":status" header, unless "envoy.reloadable_features.enable_universal_header_validator"
Expand Down Expand Up @@ -482,7 +482,7 @@ TEST_P(XdsFailoverAdsIntegrationTest, NoFailoverUseAfterPrimaryResponse) {
}

// Validate that once failover answers, primary will not be used, even after disconnecting.
TEST_P(XdsFailoverAdsIntegrationTest, NoPrimaryUseAfterFailoverResponse) {
TEST_P(XdsFailoverAdsIntegrationTest, DISABLED_NoPrimaryUseAfterFailoverResponse) {
#ifdef ENVOY_ENABLE_UHV
// With UHV the finishGrpcStream() isn't detected as invalid frame because of
// no ":status" header, unless "envoy.reloadable_features.enable_universal_header_validator"
Expand Down

0 comments on commit ae84112

Please sign in to comment.