Skip to content

Commit

Permalink
Fix the bug with dragging cursors
Browse files Browse the repository at this point in the history
  • Loading branch information
adiletelf committed Aug 30, 2024
1 parent 4e67c8c commit a3dda91
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 7 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 2.5.8
* Fix the bug with dragging cursors

## 2.5.7
* Fix rendering visual when scroll is enabled. Fix scroll arrows not being clicked
* Remove range header font size restrictions
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "powerbi-visuals-timeline",
"version": "2.5.7.0",
"version": "2.5.8.0",
"description": "Timeline slicer is a graphical date range selector used as a filtering component in the report canvas",
"repository": {
"type": "git",
Expand Down
4 changes: 2 additions & 2 deletions pbiviz.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"visual": {
"name": "Timeline",
"displayName": "Timeline 2.5.7.0",
"displayName": "Timeline 2.5.8.0",
"guid": "Timeline1447991079100",
"visualClassName": "Timeline",
"version": "2.5.7.0",
"version": "2.5.8.0",
"description": "Timeline slicer is a graphical date range selector used as a filtering component in the report canvas",
"supportUrl": "https://community.powerbi.com",
"gitHubUrl": "https://github.com/Microsoft/powerbi-visuals-timeline"
Expand Down
3 changes: 1 addition & 2 deletions src/timeLine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1141,8 +1141,7 @@ export class Timeline implements powerbiVisualsApi.extensibility.visual.IVisual
}

public onCursorDrag(event: D3DragEvent<any, ICursorDataPoint, ICursorDataPoint>, currentCursor: ICursorDataPoint): void {
const mouseEvent: MouseEvent = event.sourceEvent;
const cursorOverElement: ITimelineCursorOverElement = this.findCursorOverElement(mouseEvent.x);
const cursorOverElement: ITimelineCursorOverElement = this.findCursorOverElement(event.x);

if (!cursorOverElement) {
return;
Expand Down

0 comments on commit a3dda91

Please sign in to comment.