Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

fix: add glimming to the checked boxes in analysis & timesheet #919

Merged
merged 2 commits into from
May 22, 2023

Conversation

MitanOmar
Copy link
Member

fix #858

@MitanOmar MitanOmar requested a review from derrabauke April 25, 2023 14:03
@MitanOmar MitanOmar force-pushed the Improve-visual-indicators branch from d5d78c4 to 89ebc20 Compare May 12, 2023 13:18
@MitanOmar MitanOmar marked this pull request as ready for review May 12, 2023 13:25
@MitanOmar MitanOmar requested a review from derrabauke May 12, 2023 13:25
@MitanOmar MitanOmar force-pushed the Improve-visual-indicators branch from 89ebc20 to b1310e9 Compare May 12, 2023 14:12
@MitanOmar MitanOmar requested a review from derrabauke May 22, 2023 11:50
@derrabauke
Copy link
Contributor

It's missing the highlight for the occurrence in index/activities/templat.hbs, which was requested by #858

@MitanOmar MitanOmar force-pushed the Improve-visual-indicators branch from 72aaf69 to 4f33726 Compare May 22, 2023 12:16
@MitanOmar MitanOmar force-pushed the Improve-visual-indicators branch from 4f33726 to 73a0a04 Compare May 22, 2023 12:22
@MitanOmar MitanOmar force-pushed the Improve-visual-indicators branch from 73a0a04 to 0ae53b2 Compare May 22, 2023 13:13
@MitanOmar MitanOmar requested a review from derrabauke May 22, 2023 13:59
@derrabauke derrabauke changed the base branch from main to beta May 22, 2023 14:32
Copy link
Contributor

@derrabauke derrabauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@derrabauke derrabauke merged commit b933f78 into beta May 22, 2023
@derrabauke derrabauke deleted the Improve-visual-indicators branch May 22, 2023 14:33
derrabauke pushed a commit that referenced this pull request Jun 2, 2023
* fix: add glimming to the checked boxes in analysis & timesheet

* fix(sy-checkmark): change highlight class name with it tests
derrabauke pushed a commit to derrabauke/timed-frontend that referenced this pull request Jun 2, 2023
…is#919)

* fix: add glimming to the checked boxes in analysis & timesheet

* fix(sy-checkmark): change highlight class name with it tests
derrabauke pushed a commit to derrabauke/timed-frontend that referenced this pull request Jun 2, 2023
…is#919)

* fix: add glimming to the checked boxes in analysis & timesheet

* fix(sy-checkmark): change highlight class name with it tests
derrabauke pushed a commit to derrabauke/timed-frontend that referenced this pull request Sep 27, 2023
…is#919)

* fix: add glimming to the checked boxes in analysis & timesheet

* fix(sy-checkmark): change highlight class name with it tests
derrabauke pushed a commit to derrabauke/timed-frontend that referenced this pull request Sep 28, 2023
…is#919)

* fix: add glimming to the checked boxes in analysis & timesheet

* fix(sy-checkmark): change highlight class name with it tests
derrabauke pushed a commit to derrabauke/timed-frontend that referenced this pull request Sep 28, 2023
…is#919)

* fix: add glimming to the checked boxes in analysis & timesheet

* fix(sy-checkmark): change highlight class name with it tests
derrabauke added a commit that referenced this pull request Sep 28, 2023
* refactor(filter-sidebar): to glimmer syntax

* refactor(date-buttons): to glimmer syntax

* refactor(models): use native js classes in (#921)

* fix: use native js class in absance balance model

* fix: use native js class in absence credit model

* fix: use native js class in absence type model

* fix: use native js class in absence model

* fix: use native js class in attendance model

* fix: use native js class in billing type model

* fix: use native js class in cost center model

* fix: use native js class in customer assignee model

* fix: use native js class in customer model

* fix: use native js class in employment model

* fix: use native js class in location model

* fix: use native js class in month statistic model

* fix: use native js class in project assignee model

* fix: use native js class in public holiday model

* fix: use native js class in report intersection model

* fix: use native js class in task assingee model

* fix: use native js class in user statisitic model

* fix: use native js class in user model

* fix: use native js class in worktime balance model

* fix: use native js class in year statistic model

* refactor(loading-icon): to glimmer syntax

* refactor(duratio-since): to glimmer syntax

* refactor: adapt CSS path for file name compatibility

* refactor(filter-sidebar-label): to glimmer syntax (#929)

* fix: refactor not identical warning to glimmer component

* fix: refactor component  test of not identical warnings

* refactor(paginated-table): to glimmer syntax (#932)

* refactor(no-permission): to glimmer syntax (#930)

* fix: add glimming to the checked boxes in analysis & timesheet (#919)

* fix: add glimming to the checked boxes in analysis & timesheet

* fix(sy-checkmark): change highlight class name with it tests

* refactor: users edit credit route (#908)

* refactor: users edit credit route

* fix: use new component syntax in the template

* refactor: user edit overtime credits, and absance credits

* fix: fetching the correct data when transfering

* chore: add editors files to git ignore

* refactor(balance-donut): to glimmer sytax

* fix(balance-donut): style

* refactor(report-review-warning): to glimmer syntax

* refactor(weekly-overview): to glimmer syntax

* refactor(weekly-overview-benchmark): to glimmer syntax

* fix: weekly overview benchmark tests

* refactor(weekly-overview-day): to glimmer syntax

* fix(weekly-overview-day): use unless instead of if

* fix: `@holiday` argument name in weekly overview day template

* refactor: moment transforms classes

* refactor(worktime-balance-chart): mitigate deprecations of EmberObject.extend

* feat: login page (#915)

* feat: login page

* fix: use link-to component for routing

* fix: after logout uri in environment file

* fix: centering the clock in login page

* style(login-page): add a little margin to h1 element

* refactor(timed-clock): glimmerify component and increase clock size in login page

---------

Co-authored-by: Falk <[email protected]>

* refactor(activity-model): use modern class syntax

* refactor(task-model): use modern class syntax

* chore(progress-bar): delete unused component

* chore(paginated-table): delete unused component with it exclusive packages

* fix: implication injections in deprecation workflow

* chore: clean unused code in deprecation workflow

* refactor(reports-ability): use getter instead of local state

* refactor: replace ember-site-tour > ember-shepherd

* test(tour): adapt to new tour service

* refactor: untangle tour service implementation

* test(tour): cover all tour steps

* fix(lint): tour steps

* refactor(activities): use native class for route

* fix(protected): restore code coverage

* fix: deprecation workflows (#1024)

* fix: remove the fixed deprecations

* refactor(ember-can): usage to fix the deprecation

* refactor(user-model): to fix the deprecation

* refactor(meber-cli-mirage): to fix the deprecation

* chore: remove ember parachute (#1018)

* chore: remove ember parachute from timed fronend

* chore: create unit functions of query parameters `queryParamsState`, `resetQueryParams`

* fix: js linting to use strictEqual

* fix: cleaning the code

* refactor(statistic): template to use `setModelFilter` instate of using custom setter for dates

* refactor(analytics): controller to use utils function `queryParamsState` instate of class function

* refactor(analytics): router to use utils `resetQueryFunction`

* refactor(analysis): move `queryParamsState` to utils function

* refactor(analysis-edit): tests to be compatible with the new changes

* refactor(statistic): controller to use `queryParamsState`, `resetQueryParams` in utils function

* fix: clean not needed comment

* fix: import order after rebase

* chore: ember 4.4 upgrade (#1067)

* chore: upgrade to ember 4.4

BREAKING CHANGE: Requires node >= 16.

* chore: remove custom unique-id helper

It's included now in ember by default.

* chore(deps): use optional features package for jquery

* use optional-features package
* remove route-action-helper addon

* fix: replace ember-scrollable with simplebar

* fix(index-reports-route): add missing notification service

* fix(ember-cli-nouislider): prevent global usage of Logger

The logger was exported of the global Ember object which is
no longer available as of ember v4. Therefor we may use the
forked version of the addon. Replace addon completely in the
near future or upgrade original repository.

* refactor(unverfified-reports): prevent global ember object usage

* refactor(worktime-balance-chart): to glimmer component

* fix(page-ability): safe property access

* refactor(worktime-balance-chart): adapt integration test

* fix(user-edit-credits): do not assert default query params

---------

Co-authored-by: Mitan Omar <[email protected]>
trowik added a commit to trowik/timed-frontend that referenced this pull request Dec 5, 2023
fix(tracking): fix absence for users with multiple employments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve visual indicators for (non-)billable and needs-review
2 participants