This repository has been archived by the owner on May 13, 2024. It is now read-only.
feat: highlight rows in analysis with the review flag #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually it is tracked but if the bulk edit is canceled we don't pass it on.. That would be a nice feature but I also like this solution! However, I'm not sure if we need to use a separate color if the "needs review"-report is selected.. |
|
Actually the selection was remaining until we have refactored the whole app/analysis controller and by doing that the feature got lost. Will try to restore that functionality! |
Done here #1187 |
|
@derrabauke the real MVP. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I routinely select a bunch of rows during review, click "edit selected reports" and then realise that i cant verify them because one of them had the review flag set and now i need to reselect them all.
This is an attempt to alleviate this pain:
A nicer solution would be to track the selection of the reports in the url, but that could potentially break a lot of business logic.
I'm also aware that highlighting with colour might not be the best for colour-blind people etc. so any suggestion on how to do it better is welcome. However, I think the current little tick on the right side is too small (because I am focused on the left part of the table)