refactor(report-row): use dropTask instead of tracking

adfinis · Jan 4, 2024 · e98f797 · e98f797
1 parent 834a5ad
commit e98f797
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/app/components/report-row/component.js b/app/components/report-row/component.js
@@ -1,12 +1,11 @@
 import { action } from "@ember/object";
 import { inject as service } from "@ember/service";
 import Component from "@glimmer/component";
-import { tracked } from "@glimmer/tracking";
+import { dropTask } from "ember-concurrency";
 import ReportValidations from "timed/validations/report";
 
 export default class ReportRowComponent extends Component {
   @service abilities;
-  @tracked inUpdate = false;
 
   ReportValidations = ReportValidations;
 
@@ -28,11 +27,9 @@ export default class ReportRowComponent extends Component {
    * @method save
    * @public
    */
-  @action
-  async save(changeset) {
-    this.inUpdate = true;
-    await this.args.onSave(changeset);
-    this.inUpdate = false;
+  @dropTask
+  *save(changeset) {
+    yield this.args.onSave(changeset);
   }
   /**
    * Delete the row

diff --git a/app/components/report-row/template.hbs b/app/components/report-row/template.hbs
@@ -109,8 +109,8 @@
           type="submit"
           data-test-save-report
           class="btn btn-primary"
-          disabled={{or this.inUpdate (and (not cs.isNew) (or (not cs.isDirty) (not cs.isValid)))}}
-          {{on "click" (prevent-default (fn (optional this.save) cs))}}
+          disabled={{or this.save.isRunning (and (not cs.isNew) (or (not cs.isDirty) (not cs.isValid)))}}
+          {{on "click" (prevent-default (perform this.save cs))}}
         ><FaIcon @icon="floppy-disk" /></button>
       {{/if}}
     </div>