Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(keycloak): don't quote poolMinSize value #1354

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix(keycloak): don't quote poolMinSize value #1354

merged 2 commits into from
Dec 13, 2024
+17 −20

Conversation

cfi2017
Copy link
Contributor

@cfi2017 cfi2017 commented Dec 13, 2024 •
edited
Loading

Description

This PR fixes #1353

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@cfi2017 cfi2017 added the bug Something isn't working label Dec 13, 2024
@cfi2017 cfi2017 self-assigned this Dec 13, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 13, 2024
@cfi2017 cfi2017 force-pushed the fix/keycloak-poolMinSize-type branch from 28f2c2f to 8b8fd91 Compare December 13, 2024 10:23
@cfi2017 cfi2017 force-pushed the fix/keycloak-poolMinSize-type branch from 8b8fd91 to e32fc32 Compare December 13, 2024 10:24
@cfi2017 cfi2017 marked this pull request as ready for review December 13, 2024 10:28
@cfi2017 cfi2017 requested a review from a team as a code owner December 13, 2024 10:28
@cfi2017 cfi2017 requested review from 4censord and gianklug December 13, 2024 10:28
inisitijitty
inisitijitty approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@inisitijitty inisitijitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfi2017 cfi2017 merged commit a283b3f into main Dec 13, 2024
3 checks passed
@cfi2017 cfi2017 deleted the fix/keycloak-poolMinSize-type branch December 13, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inisitijitty inisitijitty inisitijitty approved these changes

@hairmare hairmare hairmare approved these changes

@4censord 4censord Awaiting requested review from 4censord 4censord is a code owner automatically assigned from adfinis/helm-charts

@gianklug gianklug Awaiting requested review from gianklug gianklug is a code owner automatically assigned from adfinis/helm-charts

Assignees

@cfi2017 cfi2017

Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[keycloak-operator] poolMinSize value not usable
3 participants
@cfi2017 @hairmare @inisitijitty