-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(input): allow custom date component to be configured #861
Conversation
This allows you to set "ember-validated-form": {
theme: "bootstrap",
defaults: {
"types/date": "myapp/components/my-date-picker",
},
}, The arguments passed to the datepicker are: @autocomplete={{@autocomplete}}
@autofocus={{@autofocus}}
@disabled={{@disabled}}
@id={{@inputId}}
@name={{or @inputName @name}}
@placeholder={{@placeholder}}
@type={{@type}}
@value={{@value}}
@isInvalid={{@isInvalid}}
@isValid={{@isValid}}
@setDirty={{@setDirty}}
@update={{@update}}
...attributes @czosel what do you think? |
Example: inosca/ember-ebau-gwr#382 |
I like the idea 👍 @anehx what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea! However, we should make sure that the default is an input with type date. Also, tests!
What do you mean by "we should make sure that the default is an input"? If we render the |
a5bf884
to
862f047
Compare
06586f2
to
3462d80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nitpicks, otherwise LGTM! Awesome work! 🎉
b2cdb38
to
182eca9
Compare
If none is set we just default to the `inputComponent` aka HTML5 picker. Co-authored-by: Jonas Metzener <[email protected]>
182eca9
to
9fd91ea
Compare
# [6.1.0](v6.0.2...v6.1.0) (2022-09-16) ### Features * **input:** allow custom date component to be configured ([#861](#861)) ([33bbafa](33bbafa))
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
If none is set we just default to the
inputComponent
aka HTML5 picker.